1817857 - Cannot copy text from netmonitor html preview

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect)

Description

[Alexandre Poirot [:ochameau]]

Bug 1800916 allowed selecting text, but didn't allow copying it...
I missed removing a few CSS preventing this.

STR:

• open the netmonitor
• load any HTML page on http://
• select the html page request in the netmonitor and open the response panel
• try to select and copy and paste some text from the response panel

Selecting text works, but copying the text doesn't.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1817857 - [devtools] Allow copying text from netmonitor HTML previews.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ab071df105d
[devtools] Allow copying text from netmonitor HTML previews. r=jdescottes

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6ab071df105d

Comment 4

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest Nightly build : 112.0a1 (2023-02-21).

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ochameau, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 9318840 [details]
Bug 1817857 - [devtools] Allow copying text from netmonitor HTML previews.

Beta/Release Uplift Approval Request

• User impact if declined: Users can't copy text selected in netmonitor HTML previews.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0.
• List of other uplifts needed: Bug 1818037
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only impacts this one feature.

Bug 1818037 would be nice to uplift alongside to have better test coverage.

• String changes made/needed: no
• Is Android affected?: No

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9318840 [details]
Bug 1817857 - [devtools] Allow copying text from netmonitor HTML previews.

Approved for 111.0b5

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cd2f721132c6

Comment 9

[Rares Doghi, Desktop QA]

Verified as fixed in our latest beta build 111.0b5.