Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

2 years ago

Sync web-platform-tests PR 38617 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38617
Details from upstream follow.

L. David Baron <dbaron@chromium.org> wrote:

Reland "Make inferred roles for CSS toggles influence accessibility role."

This is a reland of commit 23486a5ee14f6d10a7df673c124eaf1759ab22e4
and commit 2957ce35574b134906b8c5576627081183743706.

Original change's description:

Make inferred roles for CSS toggles influence accessibility role.

The tests added in this CL are mostly testing the inference engine added
in the previous CL.

Support for toggles is controlled by the CSSToggles flag (currently off)
in RuntimeEnabledFeatures.

Bug: 1250716
Change-Id: Ia0b38b5c7ffacc4d2a6eec88ecfe0ada852c4b09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200858
Reviewed-by: Aaron Leventhal \<aleventhal@chromium.org>
Commit-Queue: David Baron \<dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106967}

Original change's description:

Refactor CSS toggle influence on ARIA role into its own function.

Support for toggles is controlled by the CSSToggles flag (currently off)
in RuntimeEnabledFeatures.

Bug: 1250716
Change-Id: I7751d1d48a3444cc249979185ff5517ecd7c5e01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4265191
Reviewed-by: Aaron Leventhal \<aleventhal@chromium.org>
Commit-Queue: David Baron \<dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106983}

Bug: 1250716
Change-Id: I8dab23d70c84a2d3b845c79c245756ccab13e88d
Reviewed-on: https://chromium-review.googlesource.com/4269430
WPT-Export-Revision: 401d2b602c9dc5ba88d142aa704707e2060e35d8

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Component: web-platform-tests → CSS Parsing and Computation

Product: Testing → Core

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

2 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=23f5c9039542d1782e3b0906e6180814d0653e6e

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

2 years ago

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 27 subtests

Status Summary

Firefox

OK : 1
FAIL: 27

Chrome

OK : 1
PASS: 3
FAIL: 24

Safari

OK : 1
FAIL: 27

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-toggle/toggle-aria-roles.tentative.html [wpt.fyi]
- aria role test:
  <div></div>
  : FAIL (Chrome: PASS, Safari: FAIL)
- aria role test:
  <div class="root">
  <div></div>
  </div>
  : FAIL (Chrome: PASS, Safari: FAIL)
- aria role test:
  <div class="root trigger" data-expected-role="checkbox"></div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div class="root trigger" role="link" data-expected-role="link"></div>
  : FAIL (Chrome: PASS, Safari: FAIL)
- aria role test:
  <div class="root">
  <div class="trigger" data-expected-role="button"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div class="group" data-expected-role="radiogroup">
  <div class="root-group trigger" data-expected-role="radio"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div class="group" data-expected-role="radiogroup">
  <div class="root-group trigger" data-expected-role="radio"></div>
  <div class="root-group trigger" data-expected-role="radio"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div>
  <div class="root-group trigger" data-expected-role="radio"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div style="toggle-group: another-group">
  <div class="root-group trigger" data-expected-role="radio"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div style="toggle-group: another-group, test-role, third-group" data-expected-role="radiogroup">
  <div class="root-group trigger" data-expected-role="radio"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div>
  <div class="root trigger" data-expected-role="checkbox"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div>
  <div class="root trigger" data-expected-role="checkbox"></div>
  <div class="root trigger" data-expected-role="checkbox"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div class="root">
  <div class="trigger" data-expected-role="button"></div>
  <div class="visibility"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div class="root-group">
  <div class="trigger" data-expected-role="button"></div>
  <div class="visibility"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div class="root">
  <div class="trigger" data-expected-role="button"></div>
  <div class="visibility" style="position: absolute"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div class="root">
  <div class="trigger" data-expected-role="button"></div>
  <div class="visibility" style="position: fixed"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div class="root">
  <div class="trigger" data-expected-role="button"></div>
  <div class="visibility" popover="auto"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div class="root">
  <div class="trigger" data-expected-role="button"></div>
  <div class="visibility" style="position: sticky"></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div class="group">
  <div class="root-group" data-expected-role="region">
  <div class="trigger" data-expected-role="button"></div>
  <div class="visibility"></div>
  </div>
  <div class="root-group" data-expected-role="region">
  <div class="trigger" data-expected-role="button"></div>
  <div class="visibility"></div>
  </div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <div class="group">
  <div class="root-group">
  <div class="trigger" data-expected-role="button"></div>
  <div class="visibility"></div>
  </div>
  <div class="root-group">
  <div class="trigger" data-expected-role="button"></div>
  <div class="visibility"></div>
  </div>
  <div></div>
  <div></div>
  <div></div>
  </div>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <ul data-expected-role="tree">
  <li class="root-self" data-expected-role="group">
  <button class="trigger" data-expected-role="treeitem"></button>
  <ul class="visibility" data-expected-role="list">
  <li>item</li>
  <li class="root-self">
  <button class="trigger" data-expected-role="button"></button>
  <ul class="visibility" data-expected-role="list">
  <li>item</li>
  <li>item</li>
  </ul>
  </li>
  <li class="root-self">
  <button class="trigger" data-expected-role="button"></button>
  <ul class="visibility" data-expected-role="list">
  <li>item</li>
  <li>item</li>
  </ul>
  </li>
  </ul>
  </li>
  <li class="root-self" data-expected-role="group">
  <button class="trigger" data-expected-role="treeitem"></button>
  <ul class="visibility" data-expected-role="list">
  <li class="root-self">
  <button class="trigger" data-expected-role="button"></button>
  <ul class="visibility" data-expected-role="list">
  <li>item</li>
  <li>item</li>
  </ul>
  </li>
  <li class="root-self">
  <button class="trigger" data-expected-role="button"></button>
  <ul class="visibility" data-expected-role="list">
  <li>item</li>
  <li>item</li>
  </ul>
  </li>
  </ul>
  </li>
  </ul>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <section class="group" data-expected-role="tablist">
  <h1 class="root-group trigger" data-expected-role="tab"></h1>
  <div class="visibility" data-expected-role="tabpanel"></div>
  <h1 class="root-group trigger" data-expected-role="tab"></h1>
  <div class="visibility" data-expected-role="tabpanel"></div>
  <h1 class="root-group trigger" data-expected-role="tab"></h1>
  <div class="visibility" data-expected-role="tabpanel"></div>
  </section>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <section class="group" data-expected-role="tablist">
  <h1 class="root-group trigger" data-expected-role="tab"></h1>
  <div class="visibility" data-expected-role="tabpanel"></div>
  <h1 class="root-group trigger" data-expected-role="tab"></h1>
  <div class="visibility" data-expected-role="tabpanel"></div>
  <div></div>
  </section>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <section class="group" data-expected-role="tablist">
  <h1 class="root-group trigger" data-expected-role="tab"></h1>
  <div class="visibility" data-expected-role="tabpanel"></div>
  <h1 class="root-group trigger" data-expected-role="tab"></h1>
  <div class="visibility" data-expected-role="tabpanel"></div>
  <h1 style="toggle-root: other-toggle; toggle-trigger: other-toggle" data-expected-role="checkbox"></h1>
  </section>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <section class="group" data-expected-role="tablist">
  <h1 class="root-group trigger" data-expected-role="tab"></h1>
  <div class="visibility" data-expected-role="tabpanel"></div>
  <h1 class="root-group trigger" data-expected-role="tab"></h1>
  <div class="visibility" data-expected-role="tabpanel"></div>
  <h1 style="toggle-root: other-toggle; toggle-trigger: other-toggle" data-expected-role="button"></h1>
  <div style="toggle-visibility: toggle other-toggle"></div>
  </section>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <section class="group" data-expected-role="null">
  <h1 class="root-group trigger" data-expected-role="button"></h1>
  <div class="visibility"></div>
  <h1 class="root-group trigger" data-expected-role="button"></h1>
  <div class="visibility"></div>
  <div></div>
  <div></div>
  <div></div>
  <div></div>
  </section>
  : FAIL (Chrome: FAIL, Safari: FAIL)
- aria role test:
  <section class="group" data-expected-role="radiogroup">
  <h1 class="root-group trigger" data-expected-role="radio"></h1>
  <h1 class="root-group trigger" data-expected-role="radio"></h1>
  <div></div>
  <div></div>
  <div></div>
  <div></div>
  </section>
  : FAIL (Chrome: FAIL, Safari: FAIL)

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Blocks: 1818091

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Depends on: 1820357

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

2 years ago

Depends on: 1820499

Pulsebot

Comment 3

•

2 years ago

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1e50952c0f65 [wpt PR 38617] - Reland "Make inferred roles for CSS toggles influence accessibility role.", a=testonly https://hg.mozilla.org/integration/autoland/rev/81f5b975f333 [wpt PR 38617] - Update wpt metadata, a=testonly

Noemi Erli[:noemi_erli]

Comment 4

•

2 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/1e50952c0f65
https://hg.mozilla.org/mozilla-central/rev/81f5b975f333

Status: NEW → RESOLVED

Closed: 2 years ago

status-firefox112: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 112 Branch

Bugzilla

[wpt-sync] Sync PR 38617 - Reland "Make inferred roles for CSS toggles influence accessibility role."

Categories

(Core :: CSS Parsing and Computation, task, P4)

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Updated

Updated

Updated

Comment 3

Comment 4