Closed
Bug 1818090
Opened 2 years ago
Closed 2 years ago
Tweak styling of custom formatters
Categories
(DevTools :: Framework, enhancement)
DevTools
Framework
Tracking
(firefox112 fixed, firefox113 fixed)
RESOLVED
FIXED
112 Branch
People
(Reporter: sebo, Assigned: sebo)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
We want to adjust the styling of custom formatters to get as close as possible to the styling within the Chrome DevTools, especially regarding the CLJS DevTools.
Custom formatters like the CLJS DevTools rely heavily onposition: relative;
in their layouts. Applying relative positioning is already somehwhat safe to avoidlayout breakage in comparison to other position
values
Therefore, support for it should be added.
Sebastian
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED
Assignee | ||
Updated•2 years ago
|
Summary: Allow some more styling in custom formatting → Tweak styling of custom formatters
Assignee | ||
Comment 3•2 years ago
|
||
Depends on D170607
Updated•2 years ago
|
Attachment #9319200 -
Attachment description: Bug 1818090 - Added custom formatting support for position: relative. r=nchevobbe → Bug 1818090 - Added custom formatting support for position: relative and align-* and justify-* properties. r=nchevobbe
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/892e910bf90f
Added custom formatting support for position: relative and align-* and justify-* properties. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/2a23381850a1
Adjusted custom formatter styling to use inline-flex. r=nchevobbe
Comment 5•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/892e910bf90f
https://hg.mozilla.org/mozilla-central/rev/2a23381850a1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Assignee | ||
Comment 6•2 years ago
|
||
Assignee | ||
Comment 7•2 years ago
|
||
The CLJS DevTools need the vertical-align
property to properly align their icons.
Sebastian
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68f69b7e45ba
Added custom formatting support for vertical-align property. r=nchevobbe,devtools-reviewers
Comment 9•2 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•