1818141 - Search bar icon padding increased when not hovered

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Fanolian]

Attachment: Firefox searchbar icon padding.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/112.0
Build ID: 20230221212648

Steps to reproduce

1. Add search bar to toolbar.
2. Hover the magnifying glass icon once.
3. Cursor leaves the icon.

Actual result

(Please refer to the attached screenshot.)
Padding between magnifying glass icon and search term/placeholder increases. The icon which indicates an available search engine is not affected.
Search term snaps back every time the icon is hovered.

The bug is not exhibited if the icon has never been hovered after a restart.

Expected result

Search term position is consistent.
Perhaps align the padding size with that in address bar too.

Regression

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=aaf2d377bba725efc48c85e146db733f46bd486a&tochange=07438d7c237247e41dc2482c7043f84f573abd07
This is regressed by bug 1815229.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1818141 - Update image when going from non-null to null XUL image request. r=tnikkel

Otherwise we end up with a stale intrinsic size.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1818141 - Clean up a bit image updates. r=tnikkel

This shouldn't change behavior but reduces the amount of code paths
where we update the internal image state.

Depends on D170594

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1815229

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/398f2f6246cf
Update image when going from non-null to null XUL image request. r=tnikkel

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/398f2f6246cf

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reprooducible on a 2023-02-21 Nightly build on Windows 10.
Verified as fixed on Firefox 112.0b5(build ID: 20230321175953) and Nightly 113.0a1(build ID: 20230323094537) on Windows 10, macOS 12, Ubuntu 22.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ade350a1d864
Clean up a bit image updates. r=tnikkel

Comment 8

[Cristina Horotan [:chorotan]]

Backed out changeset ade350a1d864 (bug 1818141) for causing multiple failures

Backout: https://hg.mozilla.org/integration/autoland/rev/3f2f2216d95cb061668e570d332b3b3bf861965d

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ade350a1d8640b1688790681530f7ad6a17a069e

Failure logs:
bc failures: https://treeherder.mozilla.org/logviewer?job_id=416180843&repo=autoland&lineNumber=2682
chrome failures: https://treeherder.mozilla.org/logviewer?job_id=416180409&repo=autoland&lineNumber=3200
xpcshell failures: https://treeherder.mozilla.org/logviewer?job_id=416182112&repo=autoland&lineNumber=3193