1818215 - [wdspec] Update tests for pytest asyncio markers

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

In nearly all of our tests we currently use the @pytest.mark.asyncio marker for each and every test. This adds quite an overhead. Instead we can use a single pytestmark = pytest.mark.asyncio entry at the top of the file which will then automatically apply it to all the test methods within this module.

Affected tests are under:
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/webdriver/tests/bidi/

Comment 1

[Washington A. F. Silva[:Prt]]

Hello, I would like to work on this task, this is my first work however, any tips to start?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks for having you here! And I'm happy to help / assist especially when it's your very first bug!

A good place to start is the documentation for new contributors that you can find here:
https://firefox-source-docs.mozilla.org/testing/marionette/NewContributors.html

For further questions don't hesitate to contact us as best on Matrix in the mentioned #webdriver channel.

Comment 3

[Washington A. F. Silva[:Prt]]

Attachment: Bug 1818215 - [wdspec] Update tests for pytest asyncio markers. r=whimboo

The code now uses a single pytestmark = pytest.mark.asyncio instead of repeating @pytest.mark.asyncio for each test.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hi Washington. I would like to know if you have received the email from Phabricator about my code review and request for changes. If yes and you are facing troubles with the updates please let me know. Thanks!

Comment 5

[Washington A. F. Silva[:Prt]]

Yes I have received it, however i got caught up on some other things, I'll be updating it in this next days.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thank you for the reply and no worries when it takes longer. It's good that you got the email.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Washington, please let us know if you are still interested. Some additional time has passed by and the risk that the patch bitrots is high due to the activity on our side. If you still do not have the time just tell us, and we can pick it up. Thanks.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There was not reply within the last 3 weeks. As such lets open up this bug for other interested contributors.

Comment 9

[Khalid AlHaddad]

Attachment: Bug 1818215 - Update tests for pytest asyncio markers. r?#webdriver-reviewers

Comment 10

[Khalid AlHaddad]

Attachment: Bug 1818215 - Update mozilla-specific tests for pytest asyncio markers. r?#webdriver-reviewers

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that Julian started to review the patches lets set him as the mentor for this bug.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/99215a450305
https://hg.mozilla.org/integration/autoland/rev/61189d5d1cb8
Update tests for pytest asyncio markers. r=jdescottes
https://github.com/mozilla-firefox/firefox/commit/6d12599b9057
https://hg.mozilla.org/integration/autoland/rev/5f13597560c2
Update mozilla-specific tests for pytest asyncio markers. r=jdescottes

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/61189d5d1cb8
https://hg.mozilla.org/mozilla-central/rev/5f13597560c2

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58447 for changes under testing/web-platform/tests

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot