1818274 - Doxy.me is broken

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P1)

Description

[Byron Campen [:bwc]]

Based on the console logging, it seems that doxy.me is trying to set usernameFragment (which is read-only), which is leading to breakage. Unfortunately, getting a medical professional to hang around while I run a mozregression is not really an option, and they do not have any kind of call test page.

"OpenTok:SessionDispatcher:error Error occurred during processMessage +127ms TypeError: setting getter-only property "usernameFragment"
    RTCIceCandidate https://doxy.me/bundle/index.36cea6ef9826823d0f09.js:1
    processMessage https://doxy.me/bundle/index.36cea6ef9826823d0f09.js:1
    processMessage https://doxy.me/bundle/index.36cea6ef9826823d0f09.js:1
    e https://doxy.me/bundle/index.36cea6ef9826823d0f09.js:1
    p https://doxy.me/bundle/index.36cea6ef9826823d0f09.js:1
    i https://doxy.me/bundle/index.36cea6ef9826823d0f09.js:1
    t https://doxy.me/bundle/index.36cea6ef9826823d0f09.js:1
    n https://doxy.me/bundle/index.36cea6ef9826823d0f09.js:1
    s https://doxy.me/bundle/index.36cea6ef9826823d0f09.js:1
    W https://doxy.me/bundle/index.36cea6ef9826823d0f09.js:1
    T https://doxy.me/bundle/index.36cea6ef9826823d0f09.js:1
    S https://doxy.me/bundle/index.36cea6ef9826823d0f09.js:1
index.36cea6ef9826823d0f09.js:1:534400
"

Comment 1

[Byron Campen [:bwc]]

Specifically, the breakage here is that ICE fails, probably because their trickle ICE code is failing and never calling addIceCandidate.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

"OpenTok:SessionDispatcher:error Error occurred during processMessage +127ms TypeError: setting getter-only property "usernameFragment"

This JSMSG_GETTER_ONLY error message from WebIDL about usernameFragment I think pinpoints the regression.

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Treating this as defect until we can resolve the site issue.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1812346

Comment 5

[Jim Mathies [:jimm]]

so we don't lose track of this.

Comment 6

[Andreas Pehrson [:pehrsons]]

There was also https://github.com/webrtcHacks/adapter/issues/1122#issuecomment-1439513940

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

From comment 6, the bug is in adapter.js. I've left a comment there explaining it.

So this bug isn't in doxy.me, nor is it limited to doxy.me. It may affect any site relying on adapter.js for WebRTC compatibility with Firefox.

We should back out bug 1812346 to give adapter.js time to fix this, and for all users of adapter.js to update (which may be a while).

Comment 8

[Iulian Moraru]

Bug 1812346 was backed out.
Backout link: https://hg.mozilla.org/mozilla-central/rev/3dfb2505dc5b

Comment 9

[Donal Meehan [:dmeehan]]

Setting 112 to Fixed by backout - see comment 8

Comment 10

[Donal Meehan [:dmeehan]]

Setting 111 to Fixed, regressor Bug 1812346 backed out of Beta