18183 - [blocker][sink]Need new method for select content to know when complete

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[rods (gone)]

Vidur, I have decided to file a bug and mark it a blocker because I have two or
more blocker bugs depending on it and these could potentially hold M11.

Comment 1

[rods (gone)]

Change milestone to M11

Comment 2

[vidur (gone)]

Question for you Rod: Can I call the notification method after all of the
options have been added to the select, but *before* I do content notification?
Specifically, is it OK to do this notification even if no frames yet exist for
this element?

Comment 3

[vidur (gone)]

If the answer is yes, this should do you, I think:

Index: content/public/nsISelectElement.h
===================================================================
RCS file: /cvsroot/mozilla/layout/html/content/public/nsISelectElement.h,v
retrieving revision 1.2
diff -r1.2 nsISelectElement.h
42c42,43
<
---
>   NS_DEFINE_STATIC_IID_ACCESSOR(NS_ISELECTELEMENT_IID)
>
53a55,60
>
>   /**
>    * Indicates that we're done adding child content
>    * to the select during document loading.
>    */
>   NS_IMETHOD DoneAddingContent() = 0;
Index: content/src/nsHTMLSelectElement.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/content/src/nsHTMLSelectElement.cpp,v
retrieving revision 1.52
diff -r1.52 nsHTMLSelectElement.cpp
183a184
>   NS_IMETHOD DoneAddingContent();
702a704,709
> }
>
> NS_IMETHODIMP
> nsHTMLSelectElement::DoneAddingContent()
> {
>   // XXX rods to provide implementation
>   return NS_OK;
Index: document/src/nsHTMLContentSink.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/document/src/nsHTMLContentSink.cpp,v
retrieving revision 3.265
diff -r3.265 nsHTMLContentSink.cpp
76a77
> #include "nsISelectElement.h"
1257,1258d1257
<   NS_IF_RELEASE(content);
<
1280a1280,1289
>   case eHTMLTag_select:
>     {
>       nsCOMPtr<nsISelectElement> select = do_QueryInterface(content, &result);

>
>       if (NS_SUCCEEDED(result)) {
>         result = select->DoneAddingContent();
>       }
>     }
>     break;
>
1284a1294,1295
>   NS_IF_RELEASE(content);
>

Comment 4

[vidur (gone)]

Reassigning to rods since he's going to check in the patch.

Comment 5

[rods (gone)]

Method added vidur and cheked in by me, it all now works - Fixed

Comment 6

[Chris Petersen]

Rod, not sure how I can verify thi since this was a code fix. Could you please
mark this as verified ?

Comment 7

[Chris Petersen]

Based on Rod's comments, marking verified fixed in the Nov 16th build.