Closed Bug 1818322 Opened 1 year ago Closed 1 year ago

Implement a reusable component for a URL row in View

Categories

(Firefox :: Firefox View, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: mkaply, Assigned: kcochrane)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-firefox-view])

Attachments

(1 file)

Current implementations of Firefox View have a unique UI element for synced tabs and for recently closed tabs.

In both cases, they have very unique displays and very unique functionality as to what happens when they are clicked.

We'd like to implement a generic URL row that can be reused for various experiments in Firefox View.

Initially it can probably look similar to the current previous closed tab (icon, title, top level URL).

When right clicked, it should have similar options for History/bookmarks elsewhere in the browser:

Open in New Tab
Open in New Container Tab
Open in New Window
Open in New Private Window
Copy

Potentially we can have a flag that it is a history item and also add:
Delete Page
Forget about this site
Bookmark this page

Eventually we can have save to pocket as well.

But we're going to focus on the first set.

Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Attachment #9321645 - Attachment description: WIP: Bug 1818322 - Create TabItem reusable component r=sfoster,mstriemer → WIP: Bug 1818322 - Create MozTabRow reusable component r=sfoster,mstriemer
See Also: → 1821094
Attachment #9321645 - Attachment description: WIP: Bug 1818322 - Create MozTabRow reusable component r=sfoster,mstriemer → WIP: Bug 1818322 - Create MozTabRow reusable component r=sfoster,mstriemer,morgan
Attachment #9321645 - Attachment description: WIP: Bug 1818322 - Create MozTabRow reusable component r=sfoster,mstriemer,morgan → WIP: Bug 1818322 - Create MozTabList and MozTabRow reusable components r=sfoster,mstriemer,morgan
Attachment #9321645 - Attachment description: WIP: Bug 1818322 - Create MozTabList and MozTabRow reusable components r=sfoster,mstriemer,morgan → Bug 1818322 - Create MozTabList and MozTabRow reusable components r=sfoster,mstriemer,morgan
Blocks: 1821094
Pushed by kcochrane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/437a2458db3c
Create MozTabList and MozTabRow reusable components r=mstriemer,fluent-reviewers,fxview-reviewers,sfoster,Jamie,flod

Backed out for causing bc failures in moz-tab-list.mjs

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | file only referenced from unreferenced files: chrome://browser/content/moz-tab-list.css referenced from chrome://browser/content/moz-tab-list.mjs -
Flags: needinfo?(kcochrane)
Pushed by kcochrane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/08ee4eba4c40
Create MozTabList and MozTabRow reusable components r=mstriemer,fluent-reviewers,fxview-reviewers,sfoster,Jamie,flod

Backed out for causing bc failures on browser_parsable_css.js

Backout link

Push with failures

Failure log

Pushed by kcochrane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b431f0258579
Create MozTabList and MozTabRow reusable components r=mstriemer,fluent-reviewers,fxview-reviewers,sfoster,Jamie,flod
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
Depends on: 1831485
Flags: needinfo?(kcochrane)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: