1818329 - Allow negatives when parsing media feature values.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1818329 - Don't reject negative values at parse time in media features. r=dshin

Clean-up some other test expectations while at it.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1818329 - Don't reject negative resolutions either. r=jfkthame

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa64d4d68a0c
Don't reject negative values at parse time in media features. r=dshin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89c458212f3c
Don't reject negative resolutions either. r=layout-reviewers,jfkthame

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/beff44676d63
Backed out changeset 89c458212f3c for causing wpt reftest failures on image-set-invalid-resolution-rendering-2.html

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing wpt reftest failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=89c458212f3cd4439c90017d06d7a1b033cbe224&searchStr=web%2Cplat&tochange=65df162e540fcc392bd0f8fb020abbfc7f60ecee&selectedTaskRun=EwFesZQHTqi5wIJXODVqiQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=406832814&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=406832946&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=406838469&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/beff44676d63

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/fa64d4d68a0c

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c915de76eab3
Backed out changeset fa64d4d68a0c for causing wpt reftest failures on mq-negative-range-001.html. CLOSED TREE

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out for causing wpt reftest failures on mq-negative-range-001.html

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=e837c781bae16f7ad3e6f66003d7dfdc3ac998f4&test_paths=%2Fcss%2Fmediaqueries&selectedTaskRun=Vl8lVhssSACAhfom2NZQQA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=406850946&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/c915de76eab305997a531b7b0ce1cdd29f81a10e

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c7eb3fca5a8
Don't reject negative values at parse time in media features. r=dshin
https://hg.mozilla.org/integration/autoland/rev/af4cdf10aafd
Don't reject negative resolutions either. r=layout-reviewers,jfkthame

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38704 for changes under testing/web-platform/tests

Comment 12

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1818329) for causing wpt failures

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=b2M3_geIRyqJYHEWKtglkw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=af4cdf10aafd3d76b7086371a60b34a51ae9ebc1&searchStr=wpt

Log: https://treeherder.mozilla.org/logviewer?job_id=406912904&repo=autoland&lineNumber=18332
https://treeherder.mozilla.org/logviewer?job_id=406913393&repo=autoland&lineNumber=6979

Backout: https://hg.mozilla.org/integration/autoland/rev/3c0c912797194ede4d94268a41eaf4c34847d381

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c3a6a328d47
Don't reject negative values at parse time in media features. r=dshin
https://hg.mozilla.org/integration/autoland/rev/01c1a2d4f4fd
Don't reject negative resolutions either. r=layout-reviewers,jfkthame

Comment 15

[Serban Stanca [:SerbanS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/c915de76eab305997a531b7b0ce1cdd29f81a10e

Comment 16

[Serban Stanca [:SerbanS]]

Backed out for causing wpt failures in image-set-parsing.html.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /css/css-images/image-set/image-set-parsing.html | e.style['background-image'] = "image-set(url(example.png) 0x)" should not set the property value - assert_equals: expected "" but got "image-set(url("example.png") 0x)"

Comment 17

[Emilio Cobos Álvarez (:emilio)]

How in the world did this try push not catch this? ;_; https://treeherder.mozilla.org/jobs?repo=try&revision=b2ccac0a2fea59626741aa8f181dcce8b13f2e9b

Comment 18

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9f50896a6e9
Don't reject negative values at parse time in media features. r=dshin
https://hg.mozilla.org/integration/autoland/rev/50b2f3e731ef
Don't reject negative resolutions either. r=layout-reviewers,jfkthame

Comment 20

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d9f50896a6e9
https://hg.mozilla.org/mozilla-central/rev/50b2f3e731ef

Comment 21

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot