1818496 - Use location source object in all selectors still using sources Map.

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Bug 1815500 will start exposing source and sourceActor object on all location objects.
We can drastically simplify and possible get rid of long term performance issues related to the usage of internal "sources" Map coming from sources reducer.
This was used in many places to map location's sourceId to source objects.
We can removes sourcesMap.get(location.sourceId) with location.source.

Doing this may improve many critical selector performance as we would drop this sources Map argument from many createSelector's.
And ultimately, this may allow to finaly make this Map be mutable and avoid having to clone it on each incoming new source.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1818496 - [devtools] Stop using sources reducer's internal Map to map location sourceId to source objects.

This should help speed up a few critical selectors by no longer running them
anytime any source is being added/removed. In addition to removing now useless lookups in this map.

breakpointsSources could be simplified as we never had to sort the visible breakpoints as
we end up sorting by source filename.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1818496 - [devtools] Stop using sources reducer's internal Map to map location sourceId to source objects.

This should help speed up a few critical selectors by no longer running them
anytime any source is being added/removed. In addition to removing now useless lookups in this map.

breakpointsSources could be simplified as we never had to sort the visible breakpoints as
we end up sorting by source filename.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f37bad71391
[devtools] Stop using sources reducer's internal Map to map location sourceId to source objects. r=devtools-reviewers,bomsy

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6f37bad71391