Closed Bug 1818513 Opened 1 year ago Closed 11 months ago

The "Learn more" text of moz-support-link should not break across lines

Categories

(Toolkit :: UI Widgets, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: tgiles, Assigned: imlata1111, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [fidefe-reusable-components-ms3] [lang=css])

Attachments

(2 files)

The design recommendation is to prevent the "Learn more" text from splitting across two lines. We can accomplish this by using the display:inline-block rule on the a[is='moz-support-link'] selector in preferences.css.

Summary: The "Learn more" text of moz-support-link should appear on a new line → The "Learn more" text of moz-support-link should not break across lines
Whiteboard: [lang=css] [fidefe-reusable-components-ms3] → [fidefe-reusable-components-ms3] [lang=css]

Hi, I would like to help fix this bug

Hey, can I please be assigned to this issue? I already have firefox up and running on my local machine and would love to work on this issue as my first. Thank you.

(In reply to franklyn from comment #1)

Hi, I would like to help fix this bug

(In reply to Siya from comment #2)

Hey, can I please be assigned to this issue? I already have firefox up and running on my local machine and would love to work on this issue as my first. Thank you.

Needinfo'ing Tim :)

Btw, you might want to bring in :flod to verify that the proposed change is okay for all locales. I imagine it could be disadvantage when "Learn more" translates to a much longer string, or when it's even just a longer string to begin with such as "Learn more about [whatever]."

Flags: needinfo?(tgiles)

Can I work on this issue?

My setup is also ready, Please let me know if I can make a contribution.

Attached image image.png

Thanks for the reminder Dao, appreciate it!

:flod, do you foresee any issues with forcing the "Learn more" text of these new moz-support-link to potentially be on new lines in other locales? Attached is a screenshot showing one of these "Learn more" links with some modified text that moves the entire link to a new link. If the text was just "Learn more", then it would stay next to the rest of the text on the same line.

Flags: needinfo?(tgiles) → needinfo?(francesco.lodolo)

(In reply to Tim Giles [:tgiles] from comment #6)

:flod, do you foresee any issues with forcing the "Learn more" text of these new moz-support-link to potentially be on new lines in other locales? Attached is a screenshot showing one of these "Learn more" links with some modified text that moves the entire link to a new link. If the text was just "Learn more", then it would stay next to the rest of the text on the same line.

I don't think that should be problematic.

The existing translations for the stand-alone "Learn more" in mozSupportLink seem to be relatively short
https://transvision.flod.org/string/?entity=browser/browser/components/mozSupportLink.ftl:moz-support-link-text&repo=gecko_strings

Flags: needinfo?(francesco.lodolo)
Assignee: nobody → frankezeugonna
Status: NEW → ASSIGNED

hey Tim! Can I work on this bug? I am not actively working on any other bug right now. Can you assign me this? Otherwise, if there are any open bugs that need attention, I would be happy to take a look and see if I can help.

pratikaswani9333, are you still looking for a bug to work on? If so, you could pick this one up as it's been a few weeks since assigning this bug.

Lata, I'm going to see if pratikaswani9333 wishes to work on this first to give them an opportunity to contribute. If they do not wish to work on this, then I'll assign it to you.

Flags: needinfo?(pratikaswani9333)

Hey Tim! Since we didn't heard anything from pratikaswani9333. Can I work on this now?

Sure, Lata. Feel free to needinfo me if you need clarification, thanks.

Assignee: frankezeugonna → imlata1111
Flags: needinfo?(pratikaswani9333)

Hey Tim! I was looking into the bug. As you explained, it seems like to prevent the "Learn more" text from splitting across two lines we can add this line of code

a[is='moz-support-link'] {
display: inline-block;
}
should be added in preferences.css. Will this be enough to solve this issue or there is something more to be taken care of? How can I locally test it to make sure it behave expected?

Flags: needinfo?(tgiles)

Hey Lata, you can test this by going to about:preferences#privacy and modifying the "Learn more" text under "Enhanced Tracking Protection" with the devtools inspector. After modifying this string to be a bit longer, say something like "Learn more about Enhanced Tracking Protection" or any other filler you wish to use, you can resize the browser and verify the "Learn more about Enhanced Tracking Protection" doesn't jump up to the rest of the text in that section.

Flags: needinfo?(tgiles)

Thank you Tim! I have checked in my local set up. I could see the differences before and after making the changes. However, if it require any changes further let me know.

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/40c64069c3cf
The Learn more text of moz-support-link should not break across lines. r=tgiles,settings-reviewers,mconley
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.