1818526 - [wpt-sync] Sync PR 38677 - [webnn] Update float32 gemm tests to avoid catastrophic cancellation

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38677 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38677
Details from upstream follow.

BruceDai <[e-mail]> wrote:

[webnn] Update float32 gemm tests to avoid catastrophic cancellation

@fdwr I've updated previous gemm tests and also added some new tests to address your last comment to avoid catastrophic cancellation, PTAL, thanks.

gemm calculation follows the expression `alpha * A x B + beta * C`, 

first = alpha * A
second = B
third = beta * C
Each of these parts should match signs.

It's okay if alpha * A have the same sign as B.
And it's okay if alpha * A x B and beta * C have the same sign.

So if alpha * A x B is positive, then C and beta can both be positive,
or C can be negative if beta is also negative. 

Similarly, if B is positive, then it's fine for A to be negative
if alpha is also negative, because alpha * B is positive.

@Honry @dontcallmedom Please also help review this pr, thanks.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2971b2d5cde0f230b98f42ad93eecef32c8cfe9

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e66de72bf80
[wpt PR 38677] - [webnn] Update float32 gemm tests to avoid catastrophic cancellation, a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0e66de72bf80