1818530 - Broken tab sharing on Wayland

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Jan Grulich]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/110.0.0.0 Safari/537.36

Steps to reproduce:

It is not possible to share a tab on Wayland. There are actually couple of issues:

1. It is not possible to share a tab as the list in the picker is created in a way that there is supposed to be only one option.
2. A wrong capturer type is created for tab sharing (my fault)
3. We assume that tab/browser sharing will use OS dialog

Comment 1

[Jan Grulich]

Attachment: Bug 1818530 - Fix tab sharing on Wayland

Do not specify that browser/tab sharing will be using OS prompt because
xdg-desktop-portal has no information about the browser and its tabs.
Also do mot make the xdg-desktop-portal placehoder as the only item on
the list in the picker, because we want to see tabs there and these can
also show previews, which were completely disabled if PipeWire is used.
Lastly avoid creating wrong capturer when tabs are being shared.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c7935836383
Fix tab sharing on Wayland r=ng,jib

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1c7935836383