1818570 - Fix entrypoint for FxA toolbar button when not signed in, and include experiment ID and branch slugs in opened FxA page

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, task)

Description

[Mike Conley (:mconley) (:⚙️)]

A few things that I want to address here:

1. Passing the panel here caused us to default to passing fxa_app_menu as the entrypoint, which is not true in the toolbarbutton case.
2. If the user is in an experiment, we want to pass the experiment slug and variation into the FxA page via the entrypoint_experiment and entrypoint_variation URL params.

Not addressed here: I realize I goofed in bug 1816560 and named the variable for the fxaButtonVisibility feature "boolean". In the interests of speed, I think we might just have to live with that strangeness.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I have an experiment page set up at https://experimenter.services.mozilla.com/nimbus/firefox-accounts-toolbar-button-default-visibility in the review stage in case people want to test this.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1818570 - Fix entrypoint for FxA toolbarbutton and include experiment / variation slugs when opening FxA page. r?Mardak!,markh!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35ebaf6616d7
Fix entrypoint for FxA toolbarbutton and include experiment / variation slugs when opening FxA page. r=Mardak,markh

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/35ebaf6616d7

Comment 5

[Alice Varro [avarro], Ecosystem QA]

I have verified this task using the latest Firefox Nightly 112.0a1 (build ID: 20230226214053) by enrolling in the "Firefox Accounts toolbar button default visibility" experiment on Windows 10x64, macOs 12.6 and Linux Mint 20.2 and I can confirm the following:

• The Control branch has the following parameters in the URL:

  • entrypoint = fxa_app_menu
  • entrypoint_experiment = optin-firefox-accounts-toolbar-button-default-visibility
  • entrypoint_variation = control

• The Treatment branch has the following parameters in the URL:

  • entrypoint = fxa_discoverability_native
  • entrypoint_experiment = optin-firefox-accounts-toolbar-button-default-visibility
  • entrypoint_variation = treatment-a

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9319522 [details]
Bug 1818570 - Fix entrypoint for FxA toolbarbutton and include experiment / variation slugs when opening FxA page. r?Mardak!,markh!

Beta/Release Uplift Approval Request

• User impact if declined: None.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This adds some additional telemetry and entrypoint parameters to the FxA toolbar button when it's made visible by default for an experiment. It's a small, well understood, well-contained patch.
• String changes made/needed: None.
• Is Android affected?: No

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9319522 [details]
Bug 1818570 - Fix entrypoint for FxA toolbarbutton and include experiment / variation slugs when opening FxA page. r?Mardak!,markh!

Approved for 111.0b7

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e4d9bdc6e40

Comment 9

[Alice Varro [avarro], Ecosystem QA]

I have verified this task using the latest Firefox Beta 111.0b7 (Build ID: 20230228190024) by enrolling in the "Firefox Accounts toolbar button default visibility" experiment on Windows 10x64, macOS 12.6 and Linux Mint 20.2 and I can confirm that the Sign in URL contain the correct parameters on each branch.