1818599 - investigate how much of third_party/libwebrtc/sdk/android we can remove

Status: RESOLVED FIXED

(Core :: WebRTC, task, P2)

Description

[Michael Froman [:mjf]]

We may be able to avoid vendoring some unused code.

Comment 1

[Michael Froman [:mjf]]

If we find large directories we can safely remove, we should also teach vendor-libwebrtc.py how to deal w/ allow-lists as well as block-lists, and work with more than simply top-level directories.

Comment 2

[Michael Froman [:mjf]]

https://treeherder.mozilla.org/jobs?repo=try&revision=10334506dbb0b1aaa0661a261c5bf7c286fb36c8

Comment 3

[Michael Froman [:mjf]]

Attachment: Bug 1818599 - pt1 - remove third_party/libwebrtc/sdk/android/src/jni r?ng!

Comment 4

[Michael Froman [:mjf]]

Attachment: Bug 1818599 - pt2 - remove third_party/libwebrtc/sdk/android/tests r?ng!

Depends on D173343

Comment 5

[Michael Froman [:mjf]]

Attachment: Bug 1818599 - pt3 - remove third_party/libwebrtc/sdk/android/native_api r?ng!

Depends on D173344

Comment 6

[Michael Froman [:mjf]]

Attachment: Bug 1818599 - pt4 - remove third_party/libwebrtc/sdk/android/native_unittests r?ng!

Depends on D173345

Comment 7

[Michael Froman [:mjf]]

Attachment: Bug 1818599 - pt5 - remove third_party/libwebrtc/sdk/android/instrumentationtests r?ng!

Depends on D173346

Comment 8

[Michael Froman [:mjf]]

Attachment: Bug 1818599 - pt6 - remove third_party/libwebrtc/sdk/android/api/org/webrtc/OWNERS r?ng!

Depends on D173347

Comment 9

[Michael Froman [:mjf]]

Attachment: Bug 1818599 - pt7 - remove third_party/libwebrtc/sdk/android/{AndroidManifest.xml|BUILD.gn|OWNERS|README} r?ng!

Depends on D173348

Comment 10

[Michael Froman [:mjf]]

Attachment: Bug 1818599 - pt8 - teach vendor-libwebrtc.py how to remove subdirectories as well as files r?ng!

Depends on D173349

Comment 11

[Michael Froman [:mjf]]

Attachment: Bug 1818599 - pt9 - add vendor-libwebrtc.py ability to include specific files r?ng!

Depends on D173350

Comment 12

[Michael Froman [:mjf]]

Attachment: Bug 1818599 - pt10 - new script to filter git commits for the files we vendor r?ng!

Depends on D173351

Comment 13

[Michael Froman [:mjf]]

Attachment: Bug 1818599 - pt11 - use filter script to count git file changes r?ng!

This allows a more accurate file count when comparing between
the mercurial commit and the upstream git commit.

Depends on D173352

Comment 14

[Michael Froman [:mjf]]

Attachment: Bug 1818599 - pt12 - use filter script when handling renames/add/deletes r?ng!

Depends on D173353

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afd3b45ddc52
pt1 - remove third_party/libwebrtc/sdk/android/src/jni r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/8c0029b555d2
pt2 - remove third_party/libwebrtc/sdk/android/tests r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/42c2de95a85d
pt3 - remove third_party/libwebrtc/sdk/android/native_api r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/0e00a7bae64e
pt4 - remove third_party/libwebrtc/sdk/android/native_unittests r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/ad1111fff1c8
pt5 - remove third_party/libwebrtc/sdk/android/instrumentationtests r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/43c379f97744
pt6 - remove third_party/libwebrtc/sdk/android/api/org/webrtc/OWNERS r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/5f5c5b790033
pt7 - remove third_party/libwebrtc/sdk/android/{AndroidManifest.xml|BUILD.gn|OWNERS|README} r=ng,webrtc-reviewers
https://hg.mozilla.org/integration/autoland/rev/8b6b13f196cd
pt8 - teach vendor-libwebrtc.py how to remove subdirectories as well as files r=ng
https://hg.mozilla.org/integration/autoland/rev/019ef9014dfa
pt9 - add vendor-libwebrtc.py ability to include specific files r=ng
https://hg.mozilla.org/integration/autoland/rev/1bfe155229e1
pt10 - new script to filter git commits for the files we vendor r=ng
https://hg.mozilla.org/integration/autoland/rev/c93880c6b95f
pt11 - use filter script to count git file changes r=ng
https://hg.mozilla.org/integration/autoland/rev/99b2bc69cecf
pt12 - use filter script when handling renames/add/deletes r=ng
https://hg.mozilla.org/integration/autoland/rev/05eccb482410
apply code formatting via Lando

Comment 16

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/afd3b45ddc52
https://hg.mozilla.org/mozilla-central/rev/8c0029b555d2
https://hg.mozilla.org/mozilla-central/rev/42c2de95a85d
https://hg.mozilla.org/mozilla-central/rev/0e00a7bae64e
https://hg.mozilla.org/mozilla-central/rev/ad1111fff1c8
https://hg.mozilla.org/mozilla-central/rev/43c379f97744
https://hg.mozilla.org/mozilla-central/rev/5f5c5b790033
https://hg.mozilla.org/mozilla-central/rev/8b6b13f196cd
https://hg.mozilla.org/mozilla-central/rev/019ef9014dfa
https://hg.mozilla.org/mozilla-central/rev/1bfe155229e1
https://hg.mozilla.org/mozilla-central/rev/c93880c6b95f
https://hg.mozilla.org/mozilla-central/rev/99b2bc69cecf
https://hg.mozilla.org/mozilla-central/rev/05eccb482410