Closed Bug 1818599 Opened 2 years ago Closed 2 years ago

investigate how much of third_party/libwebrtc/sdk/android we can remove

Categories

(Core :: WebRTC, task, P2)

task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: mjf, Assigned: mjf)

References

Details

Attachments

(12 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

We may be able to avoid vendoring some unused code.

Assignee: nobody → mfroman
Severity: -- → S3
Depends on: 1818386
Priority: -- → P2

If we find large directories we can safely remove, we should also teach vendor-libwebrtc.py how to deal w/ allow-lists as well as block-lists, and work with more than simply top-level directories.

Blocks: 1822194
No longer depends on: 1818386

This allows a more accurate file count when comparing between
the mercurial commit and the upstream git commit.

Depends on D173352

Pushed by mfroman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/afd3b45ddc52 pt1 - remove third_party/libwebrtc/sdk/android/src/jni r=ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/8c0029b555d2 pt2 - remove third_party/libwebrtc/sdk/android/tests r=ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/42c2de95a85d pt3 - remove third_party/libwebrtc/sdk/android/native_api r=ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/0e00a7bae64e pt4 - remove third_party/libwebrtc/sdk/android/native_unittests r=ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/ad1111fff1c8 pt5 - remove third_party/libwebrtc/sdk/android/instrumentationtests r=ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/43c379f97744 pt6 - remove third_party/libwebrtc/sdk/android/api/org/webrtc/OWNERS r=ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/5f5c5b790033 pt7 - remove third_party/libwebrtc/sdk/android/{AndroidManifest.xml|BUILD.gn|OWNERS|README} r=ng,webrtc-reviewers https://hg.mozilla.org/integration/autoland/rev/8b6b13f196cd pt8 - teach vendor-libwebrtc.py how to remove subdirectories as well as files r=ng https://hg.mozilla.org/integration/autoland/rev/019ef9014dfa pt9 - add vendor-libwebrtc.py ability to include specific files r=ng https://hg.mozilla.org/integration/autoland/rev/1bfe155229e1 pt10 - new script to filter git commits for the files we vendor r=ng https://hg.mozilla.org/integration/autoland/rev/c93880c6b95f pt11 - use filter script to count git file changes r=ng https://hg.mozilla.org/integration/autoland/rev/99b2bc69cecf pt12 - use filter script when handling renames/add/deletes r=ng https://hg.mozilla.org/integration/autoland/rev/05eccb482410 apply code formatting via Lando
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: