1818639 - Improve error message for wasm out of bounds

Status: RESOLVED INVALID

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Ben Visness [:bvisness]]

Expected results:

When accessing wasm memory out of bounds, report the invalid address to the user in the error message. This may require signal handling to extract the invalid address from a system exception.

Comment 1

[Ben Visness [:bvisness]]

Attachment: WIP: Bug 1818639: WIP: Improve error reporting for wasm out of bounds.

Comment 2

[Ben Visness [:bvisness]]

The attached patch extracts the bad address from macOS system exceptions. It doesn't yet handle any other platforms, nor does it actually update the error message.

Comment 3

[Ben Visness [:bvisness]]

We were recently talking about doing something like this, but I'm not sure if any of this old work is still relevant, nor if we have another bug now where this would be a better fit.

Comment 4

[Ryan Hunt [:rhunt]]

It looks like your patch contains most of the code needed to do this. It looks like it doesn't support multi-memory though. This is the right bug to track the work.

Comment 5

[Ben Visness [:bvisness]]

Un-assigning because Ryan's work is likely to subsume it.

Comment 6

[Ryan Hunt [:rhunt]]

Subsumed by bug 2042493.