Closed Bug 1818714 Opened 1 year ago Closed 1 year ago

ProgramData/Mozilla-(UUID) directory gets a permanent `-cachePurge` file when shutting Firefox down with cache cleanup

Categories

(Core :: Networking: Cache, defect, P2)

Desktop
Windows
defect

Tracking

()

RESOLVED FIXED
114 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox110 --- wontfix
firefox111 --- wontfix
firefox112 --- wontfix
firefox113 --- wontfix
firefox114 --- fixed

People

(Reporter: saschanaz, Assigned: valentin)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [necko-triaged])

Attachments

(1 file)

There's a public report that the directory gets cache2.(timestamp).purge.bg-rm-cachePurge-(HASH) files when shutting Firefox down:

  1. Open Firefox Settings (about:preferences) page.
  2. Click on “Privacy & Security” section in left-side pane.
  3. In right-side pane, scroll down to History section and enable “Clear history when Firefox closes” option.
    PS: The same clear history when Firefox closes option can be enabled using about:config page. Just set privacy.sanitize.sanitizeOnShutdown preference/flag to True.
  4. Again click on “Settings” button given next to the clear history option and enable “Cache” option only as shown in following screenshot:

After enabling the option, I closed Firefox and I checked the “C:\ProgramData\Mozilla-1de4eec8-1241-4177-a864-e594e8d1fb38” folder again. I was surprised to see a new file “Cache2.2023-xx.purge.bg_rm-cachePurge-308046B0AF4A39CB” created in the folder. The file size was 0 bytes and Windows was unable to detect its file type. Windows was showing it as an unknown “.bg_rm-cachePurge-308046B0AF4A39CB file” as the extension was automatically taken from the file name.

That should be being created by CachePurgeLock calling MultiInstanceLock.

The similar UpdateLock- has a removal logic, maybe the cache purger needs an equivalent?

Hi Valentin,

Could you take a look? Thanks.

Flags: needinfo?(valentin.gosu)
QA Whiteboard: [qa-regression-triage]
Assignee: nobody → valentin.gosu
Severity: -- → S4
Flags: needinfo?(valentin.gosu)
Priority: -- → P2
Whiteboard: [necko-triaged]

Regression investigation results:
Bug 1774840 - Implement new GC instructions in baseline (Part 3). r=rhunt.
Adds wasm baseline implementation and test cases for array.new_fixed.
Differential Revision: https://phabricator.services.mozilla.com/D154230

QA Whiteboard: [qa-regression-triage]
Regressed by: 1774840
Hardware: Unspecified → Desktop

I think this is actually regressed by bug 1786256.

OS: Unspecified → Windows
Regressed by: 1786256
No longer regressed by: 1774840
Attachment #9330418 - Attachment description: Bug 1818714 - ProgramData/Mozilla-(UUID) directory gets a permanent `-cachePurge` file when shutting Firefox down with cache cleanup r=#necko → Bug 1818714 - Remove cachePurge lock file after running BackgroundTask_removeDirectory r=#necko
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7c343aa2fe80
Remove cachePurge lock file after running BackgroundTask_removeDirectory r=necko-reviewers,saschanaz,jesup

It seems the test broke because it found a very old lock file.
I added a task that cleans up older locks before checking that newer locks also get removed. I'll push it again after a clean try run.

Flags: needinfo?(valentin.gosu)
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f99ee8082b68
Remove cachePurge lock file after running BackgroundTask_removeDirectory r=necko-reviewers,saschanaz,jesup
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: