Open Bug 1818772 Opened 2 years ago Updated 2 years ago

On about:glean we don't say when you should express the instrumented behaviour

Categories

(Toolkit :: Telemetry, task, P3)

task

Tracking

()

People

(Reporter: chutten, Unassigned)

References

(Blocks 1 open bug)

Details

about:glean aims to be a complete algorithm for manually testing instrumentation... but it doesn't say when to express the instrumented behaviour.

For example, if closing a tab records an event metric, then tagging and sending the "events" ping won't contain the instrumentation under test unless you've first closed a tab. So we might want a `Step 0. Express the instrumented behaviour (e.g. if your instrumentation only records when you add a bookmark: Add a bookmark first.)

Now we should be wary. If expressing the instrumentation sends a ping, then this will not be good advice. For example, if closing a tab instead sends a "tab-closed" ping, then the steps would need to be different. You want to tag a ping (and set log pings) first and then express the instrumented behaviour.

(Also, while we're here, we should probably add a Services.fog.testFlushAllChildren(); to the "Apply Settings and Submit Ping" button to ensure no one has to think about how IPC throws even more wrenches in the works)

You need to log in before you can comment on or make changes to this bug.