Closed Bug 1818789 Opened 7 months ago Closed 6 months ago

Implement Safari / macOS permission wizard page for Passwords

Categories

(Firefox :: Migration, enhancement)

Product:
Firefox
Component:
Migration
Platform:
Desktop
macOS
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: kpatenio, Assigned: alew7)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 3 obsolete files)

icon-3dots.svg
608 bytes, image/svg+xml
Details
Bug 1818789 - Implement Safari / macOS permission wizard page for Passwords. r?mconley
48 bytes, text/x-phabricator-request
Details | Review

+++ This bug was initially created as a clone of Bug #1803445 +++

We will need to implement the part of the wizard that asks the user to obtain permission from macOS to access Safari's internal data, this time for passwords.

Please see this Figma: https://www.figma.com/file/PcMkM0ZaSSy3zmS3CYGWNj/Handover---students?node-id=529%3A9708&t=Q7xdrHtnJuLEkSbf-0

No longer depends on: 1803445
Assignee: nobody → alew7
No longer blocks: 1801313
Attached image safari-icon-3dots.svg (obsolete) —
Attachment #9322728 - Attachment description: icon-3dots.svg → safari-icon-3dots.svg
Attached image safari-icon-document.svg (obsolete) —

I mentioned this in Matrix, but duplicating it here too for the record - for each of these two icons:

  1. Place them in browser/themes/shared/migration/
  2. Run hg add <path> on each of them so that Mercurial will start paying attention to them
  3. Add these lines to browser/themes/shared/jar.inc.mn, right after the other migration lines
skin/classic/browser/migration/safari-icon-3dots.svg                   (../shared/migration/safari-icon-3dots.svg)
skin/classic/browser/migration/safari-icon-document.svg                   (../shared/migration/safari-icon-document.svg)

After running ./mach build faster, you should then be able to refer to these icons with:

chrome://browser/skin/migration/safari-icon-3dots.svg and chrome://browser/skin/migration/safari-icon-document.svg

Attachment #9322728 - Attachment is obsolete: true
Attachment #9322730 - Attachment is obsolete: true
Attached image icon-3dots.svg —

This SVG has now been compressed and the license header added.

Attached image icon-document.svg (obsolete) —
Attachment #9323978 - Attachment mime type: text/plain → image/svg+xml

@mconley, we already have this icon in the codebase, can it be reused instead of the icon mentioned above?

Flags: needinfo?(mconley)

Ah, yes! Thanks Itiel, good find!

Alvin, you can reference that image with url(chrome://global/skin/icons/page-portrait.svg);.

Flags: needinfo?(mconley)
Attachment #9323978 - Attachment is obsolete: true
Attachment #9324896 - Attachment description: WIP: Bug 1818789 - Implement Safari / macOS permission wizard page for Passwords. r?mconley → Bug 1818789 - Implement Safari / macOS permission wizard page for Passwords. r?mconley
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31631cb446cc
Implement Safari / macOS permission wizard page for Passwords. r=mconley,fluent-reviewers,flod

https://hg.mozilla.org/mozilla-central/rev/31631cb446cc

Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.