1818804 - Improve installation of puppeteer (objdir, only if needed)

Status: RESOLVED WONTFIX

(Remote Protocol :: Agent, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Currently Puppeteer is getting installed into the srcdir. This is suboptimal given that it requires a couple of entries to .hgignore and .gitignore. To prevent that we should install Puppeteer into the objdir instead. npm install provides a --prefix for that purpose.

When doing that we should also make sure that we call npm install not every time when mach puppeteer-test is run but only if the Puppeteer version in the srcdir doesn't match the one in the objdir. This can be done given that there have been made massive improvements in only compiling the modified Typescript code, eg. after making a change to a test file you basically won't have to wait the up to 40s until the tests start. Instead it happens immediately!

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ideally we actually don't want to install Puppeteer anymore but have it downloaded as fetch artifact.