1818819 - Set pref layout.css.forced-color-adjust.enabled to true by default

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Fred Chasen [:fchasen]]

Set the pref for layout.css.forced-color-adjust.enabled to true by default to enable it to be used to prevent applying forced colors on certain elments.

Comment 1

[Fred Chasen [:fchasen]]

Attachment: Bug 1818819 - Enable support for forced-color-adjust property by default r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/251530e20422
Enable support for forced-color-adjust property by default r=emilio

Comment 3

[Sandor Molnar]

Backed out for causing xpc failures in devtools/shared/tests/xpcshell/test_css-properties-db.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/5aa2b55eb19b133d270affbe0279338a0ad2b547

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | devtools/shared/tests/xpcshell/test_css-properties-db.js | run_test/< - [run_test/< : 100] The static database and platform do not agree on the property "forced-color-adjust"

[Failure log bc -> TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Unused whitelist item: {"sourceName":"/web\/viewer\.css$/i","errorMessage":"/Unknown property ‘forced-color-adjust’](https://treeherder.mozilla.org/logviewer?job_id=410433442&repo=autoland&lineNumber=4521)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f0a3d3602d8
Enable support for forced-color-adjust property by default r=emilio

Comment 5

[Atila Butkovits]

Backed out for causing failures at browser_parsable_css.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/ff84e2935cc3c0b1a61d28165919e628aabae448

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=0f0a3d3602d824152a71a12c9750faa39833b170&selectedTaskRun=WMxcR3cgQMmw5LcnvXaCag.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=410559253&repo=autoland&lineNumber=4884

Comment 6

[Fred Chasen [:fchasen]]

Updated again, I had to remove this property from the whitelist now that it is enabled.

Tests appear to all be passing now:

• https://treeherder.mozilla.org/jobs?repo=try&revision=d44359490f773c310581e45908e3755410496820
• https://treeherder.mozilla.org/jobs?repo=try&revision=0629a5b4faf8e75bd02644047306af37bbe9afe3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Is this something we should call out in the Fx113 relnotes?

Comment 8

[Fred Chasen [:fchasen]]

I think a quick mention would make sense, the intent to ship was in https://groups.google.com/a/mozilla.org/g/dev-platform/c/HCTHp4XMCKk/m/SN5Iboy_AQAJ

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please set the relnote-firefox dropdown to ? and fill out the form then :-)

Comment 10

[Fred Chasen [:fchasen]]

Release Note Request

[Why is this notable]:
The “forced-color-adjust” property allows opting an element out of automatic color adjustment in Forced Color Mode.

[Affects Firefox for Android]:
Better support for High Contrast Mode colors.

[Suggested wording]:
The default “auto” value allows the colors to be automatically adjusted.

The “none” value opts out of any color changes. In combination with the “forced-color: active” media feature will allow authors to specify the exact colors that are used in situations where the automatically picked contrasting colors are not ideal.

“preserve-parent-color” is not implemented, as Firefox does not currently apply forced colors to SVG.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/129ee0d341a2
Enable support for forced-color-adjust property by default r=emilio

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/129ee0d341a2

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx113 Nightly relnotes.