1818857 - If retriggers fail on PerfHerder due to authentication issues, the error message gets thrown off the top of the viewport

Status: NEW

(Tree Management :: Perfherder, defect)

Description

[Daniel Holbert [:dholbert]]

(sorry, I don't have exact steps-to-reproduce, since this happened when I somehow got into a "treeherder shows me being logged in but my credentials are stale" sort of state. I'll do my best to describe.)

STEPS TO REPRODUCE:

1. Be logged in to TreeHerder with credentials that are invalid (I'm not sure exactly how), such that retrigger attempts on TreeHerder will fail for you. In my case, they were failing with:

Retrigger failed with Decision task: LawvxbPdQqmMatjbvEv4IA: Error: Client with clientId 'mozilla-auth0/ad|Mozilla-LDAP|dholbert/treeherder-production-client-d43TZl' is disabled

2. Visit a PerfHerder compare-revisions page like https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=2e7f0ba2d404fad8ef8c44d2d037341bae0a8cd5&newProject=try&newRevision=fc3a8061a5cbefff2728480e2ab02587a4491010&framework=13&page=1&filter=loadtime+cold+webrender
3. Hover an entry in the "Total Runs" column so that the circle "retrigger" icon shows up. Click through that to generate some retriggers.
4. Look for the retrigger error message.

ACTUAL RESULTS:
The retrigger error message (the error text quoted in step 1 above) appears off-the-top-of-the-viewport, so I didn't actually see it at first. I had to scroll up (into scrollable area that was created before all of the main page content) in order to see it.

EXPECTED RESULTS:
Error messages should be visible and probably want to be created as an overlay.

I'm using Firefox Nightly 112.0a1 (2023-02-24) on Ubuntu 22.04

Note: I don't know precisely how I got into the invalid-authentication state that I was in, but that state seems to be required in order to trigger this bug. After logging out and logging back in to TreeHerder, I'm able to do retriggers successfully (which means I can't reproduce this bug anymore).

This bug report is essentially intended to be about where-does-the-error-message-go-on-perfherder-when-retriggers-fail.