1818998 - Rework socket arrays to eliminate manual array management

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

The socket arrays in nsSocketTransportService are manually managed, which increases the chances of mistakes and makes the code fragile and hard to modify or reason about. This is some of the oldest code in gecko.

Switching them to nsTArrays would be a win.

One thing to avoid performance issues is easy ways to find out if a SocketContext* is a member of an array, or to find the index of so it can be removed in O(1). Implementing a SockIndex() function can solve this.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1818998: Convert nsSocketTransportService polling arrays to nsTArrays r=valentin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a66f82632b9
Convert nsSocketTransportService polling arrays to nsTArrays r=valentin,necko-reviewers,kershaw

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9a66f82632b9

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing leakcheck/assertion failures

Backout link

Push with failures - wpt
Push with failures - Wr

Failure log - wpt
Failure log - Wr

Bug 1822739 seems to be the same underlying issue.

Comment 5

[Cristian Tuns]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/11e6330ee008

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc84799cb093
Convert nsSocketTransportService polling arrays to nsTArrays r=valentin,necko-reviewers,kershaw

Comment 7

[Cristian Tuns]

Backed out for causing xpcshell failures in dom/base/test/unit_ipc/*

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-TIMEOUT | dom/base/test/unit_ipc/test_bug553888_wrap.js | Test timed out

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0bb02bf1e60
Convert nsSocketTransportService polling arrays to nsTArrays r=valentin,necko-reviewers,kershaw

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c0bb02bf1e60