1819001 - [Downloads v2] download can not resume

Status: RESOLVED FIXED

(Firefox for Android :: Downloads, defect, P3)

Description

[xl19870217]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36

Steps to reproduce:

pause downlaod status, then resume downlad file. it will failed.
https://romspure.cc/download/metal-gear-solid-3-snake-eater-16042/2
it is well when i use chrome browser.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Alexandra Virvara]

The described problem doesn't seem to be Android related. It also appears on the desktop version, so it might be an error that is thrown from Gecko.
I did a small investigation and I'll be adding some screen records and some logs that might be helpful when investigating further.

Comment 3

[Alexandra Virvara]

Attachment: The response headers that are received after the download is resumed (for the case where the bug doesn't reproduce))

Comment 4

[Alexandra Virvara]

Attachment: The response headers that are received after the download is resumed (for the case where the bug happens)

Comment 5

[Alexandra Virvara]

Attachment: Desktop: the download works well after resuming it

Comment 6

[Alexandra Virvara]

Attachment: Mobile: the download doesn't work after resuming it

Comment 7

[Alexandra Virvara]

Attachment: Desktop: the download doesn't work after resuming it

Comment 8

[Alexandra Virvara]

Attachment: Mobile: the download works well after resuming it

Comment 9

[Iorga Gabriel]

I think the problem is we put the "Range" header value when the download is resumed, but the website doesn't respond with the "Content-Range" header value.
The response should be 206 from the resume, but the site response is 200, like we made the request from the beginning.
The same bug is on desktop. On Chrome or Brave I can't reproduce this bug.
Tried with HttpURLConnectionClient() instead of GeckoViewFetchClient still the same result.

Comment 10

[Mira Lobontiu (Android QA)]

This issue no longer reproduces on the latest builds of Firefox for Android Nightly 152, Beta 151, or RC 150.0.1.
Tested with Motorola Moto g30 (Android 12), and Pixel 6 (Android 17).
Closing as WORKSFORME.
Feel free to file a mew issue, if encountered again.

Comment 11

[Titouan Thibaud [:titouan]]

I can still reproduce the bug. I have a clear STR that always works for me:

STR

• have a local folder, with a 500Mb file for example (that can be downloaded from here)
• open a terminal in this folder and run python3 -m http.server
• on your Android device, open Fenix and load 192.168.1.x:8000 and download the file (you need to figure out the local ip of your machine running the local server. On a mac, you can run ipconfig getifaddr en0;)
• pause the download before it completes
• resume the download

Expected behavior

• The download resumes

Actual behavior

• The download fails

Comment 12

[Titouan Thibaud [:titouan]]

Attachment: Bug 1819001 - Part 1: Refactor Downloads resume logic before fixing a Download resume issue.

Comment 13

[Titouan Thibaud [:titouan]]

Attachment: Bug 1819001 - Part 2: Restart downloads when resume response ignores Range.

When resuming a paused download, servers may ignore the Range request and respond with 200 OK instead of 206 Partial Content. Treat that as a fresh download instead of failing: reset copied byte state, attempt to delete the partial file, and write without appending.

Keep invalid resume responses failing, including 206 responses without Content-Range.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3646139bf45c
https://hg.mozilla.org/integration/autoland/rev/2654c1ea107c
Part 1: Refactor Downloads resume logic before fixing a Download resume issue. r=android-reviewers,calu

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/560649d10e02
https://hg.mozilla.org/integration/autoland/rev/7a2c34e91ca2
Part 2: Restart downloads when resume response ignores Range. r=android-reviewers,calu

Comment 16

[amarc]

https://hg.mozilla.org/mozilla-central/rev/2654c1ea107c
https://hg.mozilla.org/mozilla-central/rev/7a2c34e91ca2