1819084 - High Freq browser/base/content/test/performance/browser_tabclose.js | unexpected changed rect: ({x1:12, x2:27, y1:14, y2:29, w:16, h:16}), window width: 1280 - when Gecko 112 merges to Beta on 2023-03-13

Status: VERIFIED FIXED

(Toolkit :: Performance Monitoring, defect)

Description

[Cristina Horotan [:chorotan]]

[Tracking Requested - why for this release]:

• Central-as-beta-simulation
• How to run these simulations
• Failure log

[task 2023-02-27T13:13:53.400Z] 13:13:53     INFO - comparing 4 frames
[task 2023-02-27T13:13:53.400Z] 13:13:53     INFO - Buffered messages finished
[task 2023-02-27T13:13:53.400Z] 13:13:53     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_tabclose.js | unexpected changed rect: ({x1:12, x2:27, y1:14, y2:29, w:16, h:16}), window width: 1280 - 
[task 2023-02-27T13:13:53.400Z] 13:13:53     INFO - Stack trace:
[task 2023-02-27T13:13:53.400Z] 13:13:53     INFO - chrome://mochikit/content/browser-test.js:test_ok:1465
[task 2023-02-27T13:13:53.400Z] 13:13:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:reportUnexpectedFlicker/rects<:638
[task 2023-02-27T13:13:53.401Z] 13:13:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:reportUnexpectedFlicker:629
[task 2023-02-27T13:13:53.401Z] 13:13:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:withPerfObserver:698
...
task 2023-02-27T13:13:53.608Z] 13:13:53     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_tabclose.js | should have 0 unknown flickering areas - "Got 1, expected +0"
[task 2023-02-27T13:13:53.608Z] 13:13:53     INFO - Stack trace:
[task 2023-02-27T13:13:53.609Z] 13:13:53     INFO - chrome://mochikit/content/browser-test.js:test_is:1493
[task 2023-02-27T13:13:53.610Z] 13:13:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:reportUnexpectedFlicker:655
[task 2023-02-27T13:13:53.611Z] 13:13:53     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:withPerfObserver:698
[task 2023-02-27T13:13:53.612Z] 13:13:53     INFO - TEST-PASS | browser/base/content/test/performance/browser_tabclose.js | No reflows are expected when closing a tab - 

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox112 (nightly). We have limited time to fix this, the soft freeze is in 9 days. However, the bug still isn't assigned.

:fdoty, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 2

[Frank Doty [:fdoty]]

:florian based on /browser_tabclose.js it seems that perhaps you and :mconley may have more information on how this ticket should be handled

Comment 3

[Florian Quèze [:florian]]

Probably needs the same fix as https://hg.mozilla.org/integration/autoland/rev/07438d7c2372, it's not obvious to me why this doesn't fail on mozilla-central.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

This is a reminder regarding comment #1!

The bug is marked as tracked for firefox112 (nightly). We have limited time to fix this, the soft freeze is in 3 days. However, the bug still isn't assigned.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=6bc97d9ca7d8912c08638fb8fc4028e767092050

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1819084 - Add exception to browser_tabclose.js flicker test for Firefox View button icon. r?florian!

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Thanks for taking this Mike, sorry, it got buried in the ni? queue :/

Comment 8

[Mike Conley (:mconley) (:⚙️)]

np! Thanks for the reviews! New try push: https://treeherder.mozilla.org/jobs?repo=try&revision=481e0f22673ab8e92a122da6e9133a423121cf38

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7117b3d6cec
Add exception to browser_tabclose.js flicker test for Firefox View button icon. r=florian

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d7117b3d6cec

Comment 11

[Iulian Moraru]

Fix verified in today's central as early beta simulation.