1819147 - Services.cache2.clearOriginAttributes() does not clear all cache entries of specified userContext

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect, P2)

Description

[Max Schmitt]

Steps to reproduce:

1. Navigate to http://example.com/
2. go to about:cache
3. observe http://example.com/ entry with O^partitionKey=%28http%2Cexample.com%29, as a key. (and more)
4. Open Browser Toolbox (needs to be enabled in DevTools first)
5. Execute Services.cache2.clearOriginAttributes(JSON.stringify({ userContextId:0 }))
6. go to about:cache again (make sure to reload)

Actual results:

Observe no entries which are about http://example.com

Expected results:

http://example.com/favicon.ico
and
http://example.com/
are still there.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Networking: Cache' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Max Schmitt]

In CacheFileIOManager::EvictByContextInternal the function Equals() gets called which uses OriginAttributes== where the mPartitionKey gets strictly compared.

In our scenario the cache entry has a mPartitionKey of "(http,example.com)" and we compare it against "".

From my understanding when calling this method, mPartitionKey should not be compared against.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Hi Ed,

Could you take this? I think we need to add another EqualsIgnoringFPD method here that does:

https://searchfox.org/mozilla-central/rev/00ea1649b59d5f427979e2d6ba42be96f62d6e82/netwerk/base/nsILoadContextInfo.idl#62-67

  bool EqualsIgnoringFPD(nsILoadContextInfo *aOther)
  {
    return IsAnonymous() == aOther->IsAnonymous() &&
           OriginAttributesPtr()->EqualsIgnoringFPD(*aOther->OriginAttributesPtr())
  }
%}

Then change CacheFileIOManager::EvictByContextInternal to call EqualsIgnoringFPD.

A test would be nice too I suppose.

Comment 4

[edgul]

Sorry for the delay on this. I'd like to confirm the desired behavior on this, the actual/expected description seems like it might be backwards?:

Actual results:
Observe no entries which are about http://example.com
Expected results:
http://example.com/favicon.ico
and
http://example.com/
are still there.

Comment 5

[edgul]

Noting the correction:

Actual results:
http://example.com/favicon.ico
and
http://example.com/
are still there.

Expected results:
Observe no entries which are about http://example.com

Comment 6

[edgul]

Attachment: Bug 1819147 - Fixed clearOriginAttributes not clearing all cache entries specificed with userContext r?valentin

Comment 7

[edgul]

Attachment: Bug 1819147 - Fixed clearOriginAttributes not clearing all cache entries specificed with userContext r?valentin

Comment 8

[edgul]

Attachment: Bug 1819147 - Fixed clearOriginAttributes not clearing all cache entries specificed with userContext r?valentin

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5acfd034c3f
Fixed clearOriginAttributes not clearing all cache entries specificed with userContext r=valentin,necko-reviewers

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a5acfd034c3f