Closed Bug 1819174 Opened 1 year ago Closed 1 year ago

Update test suite tags for each Remote Protocol component

Categories

(Remote Protocol :: Agent, task, P3)

task

Tracking

(firefox113 fixed)

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: jdescottes, Assigned: victoria.o.ajala, Mentored)

References

Details

(Whiteboard: [lang=js])

Attachments

(1 file)

See https://phabricator.services.mozilla.com/D171107#inline-943905

We could set specific tags for our various test suites to easily filter them. At the moment they all use "remote" as tag name.

Mentor: hskupin
Priority: -- → P3
Whiteboard: [lang=js]

I am looking for some harder bugs( which can be a second or third good-first issue), so I want to work on this. I tried to understand the conversation in the provided link and searched for this file, but again I was unsuccessful. Can you guide me with this bug?

Sure. So basically you want to have a look at the browser.ini files under /remote. There we would have to update the tag field under the DEFAULT section to make use of the correct protocol. For tests under /remote/cdp this should be cdp.

Here an example of how it would look like:
https://phabricator.services.mozilla.com/D171107?vs=686491&id=686519#toc

Let me know if you have further questions. Thanks!

Flags: needinfo?(tiwari.abhishektiwari23)

I wanted to update you regarding the status of the assigned bugs. Initially, I had planned to complete all the assigned bugs before starting work on the new one. As a result, there has been a delay in starting work on the new bug you assigned to me. However, I am happy to inform you that all the assigned bugs are currently in the review phase, except for one. I will make sure to complete that bug by the end of the day and start working on the new one as soon as possible.

Flags: needinfo?(tiwari.abhishektiwari23)

Hi Abhishek, I hope you are doing well and want to ask if you had the time to continue on this bug or if you wont have the time. Please let me know. Thanks!

Hi, I would like to work on this if it is available.

Yes, the bug is open, and you can try it. Because of my exam last week, I was completely inactive, and I also had to cover the already assigned bugs, so I think you can try this bug until I complete my task.
Thanks.

Thanks Abhishek
I have gone through the comments and instructions Henrik made and have started working on it, I'm assuming the fix will be in remote/webdriver-bidi/test/browser/browser.ini by replacing the tags = "remote" to "wd" which is the Webdriver.
I will be submitting a patch soon @Henrik Skupin

Hi Victoria. The updates are necessary for all the browser chrome related ini files under /remote. The value is dependent on in which folder the tests exist. So for Webdriver you are right, and for CDP it should be cdp. Thanks!

Assignee: nobody → victoria.o.ajala
Status: NEW → ASSIGNED

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #8)

Hi Victoria. The updates are necessary for all the browser chrome related ini files under /remote. The value is dependent on in which folder the tests exist. So for Webdriver you are right, and for CDP it should be cdp. Thanks!

Okay, Got it!
There are two files under the CDP which are remote/cdp/test/browser/browser_cdp_only.ini and remote/cdp/test/browser/browser.ini with the same remote tags, should both of these files be updated?

Yes, and as well all the browser.ini files that live in the respective sub directories as well.

I just updated all the files and pushed them to the same patch I created but I can't seem to find my changes except the first one I made, I'm trying to figure out what I did wrong.

Attachment #9326232 - Attachment description: Bug 1819174 Update test suite default tag for remote protocol component to WebDriver. r=whimboo → Bug 1819174 Update test suite default tags for remote protocol component. r=whimboo

I figured it out @whimboo

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d67cd93843da
Update test suite default tags for remote protocol component. r=whimboo,webdriver-reviewers
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: