Update test suite tags for each Remote Protocol component
Categories
(Remote Protocol :: Agent, task, P3)
Tracking
(firefox113 fixed)
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: jdescottes, Assigned: victoria.o.ajala, Mentored)
References
Details
(Whiteboard: [lang=js])
Attachments
(1 file)
See https://phabricator.services.mozilla.com/D171107#inline-943905
We could set specific tags for our various test suites to easily filter them. At the moment they all use "remote" as tag name.
Updated•2 years ago
|
Comment 1•2 years ago
|
||
I am looking for some harder bugs( which can be a second or third good-first issue), so I want to work on this. I tried to understand the conversation in the provided link and searched for this file, but again I was unsuccessful. Can you guide me with this bug?
Comment 2•2 years ago
|
||
Sure. So basically you want to have a look at the browser.ini
files under /remote
. There we would have to update the tag
field under the DEFAULT
section to make use of the correct protocol. For tests under /remote/cdp
this should be cdp
.
Here an example of how it would look like:
https://phabricator.services.mozilla.com/D171107?vs=686491&id=686519#toc
Let me know if you have further questions. Thanks!
Updated•2 years ago
|
Comment 3•2 years ago
|
||
I wanted to update you regarding the status of the assigned bugs. Initially, I had planned to complete all the assigned bugs before starting work on the new one. As a result, there has been a delay in starting work on the new bug you assigned to me. However, I am happy to inform you that all the assigned bugs are currently in the review phase, except for one. I will make sure to complete that bug by the end of the day and start working on the new one as soon as possible.
Comment 4•2 years ago
|
||
Hi Abhishek, I hope you are doing well and want to ask if you had the time to continue on this bug or if you wont have the time. Please let me know. Thanks!
Assignee | ||
Comment 5•2 years ago
|
||
Hi, I would like to work on this if it is available.
Comment 6•2 years ago
|
||
Yes, the bug is open, and you can try it. Because of my exam last week, I was completely inactive, and I also had to cover the already assigned bugs, so I think you can try this bug until I complete my task.
Thanks.
Assignee | ||
Comment 7•2 years ago
|
||
Thanks Abhishek
I have gone through the comments and instructions Henrik made and have started working on it, I'm assuming the fix will be in remote/webdriver-bidi/test/browser/browser.ini by replacing the tags = "remote" to "wd" which is the Webdriver.
I will be submitting a patch soon @Henrik Skupin
Comment 8•2 years ago
|
||
Hi Victoria. The updates are necessary for all the browser chrome related ini files under /remote
. The value is dependent on in which folder the tests exist. So for Webdriver you are right, and for CDP it should be cdp
. Thanks!
Assignee | ||
Comment 9•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Comment 10•2 years ago
|
||
(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #8)
Hi Victoria. The updates are necessary for all the browser chrome related ini files under
/remote
. The value is dependent on in which folder the tests exist. So for Webdriver you are right, and for CDP it should becdp
. Thanks!
Okay, Got it!
There are two files under the CDP which are remote/cdp/test/browser/browser_cdp_only.ini
and remote/cdp/test/browser/browser.ini
with the same remote tags, should both of these files be updated?
Comment 11•2 years ago
|
||
Yes, and as well all the browser.ini
files that live in the respective sub directories as well.
Assignee | ||
Comment 12•2 years ago
|
||
I just updated all the files and pushed them to the same patch I created but I can't seem to find my changes except the first one I made, I'm trying to figure out what I did wrong.
Updated•2 years ago
|
Assignee | ||
Comment 13•2 years ago
|
||
I figured it out @whimboo
Comment 14•2 years ago
|
||
Comment 15•2 years ago
|
||
bugherder |
Description
•