1819266 - Table borders rendered incorrectly when table contains empty rows

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect)

Description

[Michael Hohner]

Attachment: collapse.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

Tables containing empty rows are rendered incorrectly when border-collapse=collapse.

No problem with Chrome.

See test case and screenshot.

Also happens with FF for Android.

Comment 1

[Michael Hohner]

Attachment: collapse.png

Rendering on FF

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b9ffb07cf8e71b1f4285ec7741f6b2f8256dc79d&tochange=8645a74bbbd06b67699317df1abf3897db0e43d5
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3ce5a9419d5b7a976d442901c04995c22e014bf1&tochange=9d99ac9ae088bcee2b7f89f2aff10ff0bea73f56

Suspect : Bug 895096

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 895096

Comment 4

[David Shin[:dshin]]

Attachment: Mimimum Reproducible Case

Further reduced.
Fairly sure it's pointing to the same root cause, but will have to verify.

Comment 5

[David Shin[:dshin]]

Attachment: Bug 1819266: Ensure block-direction collapsed border does not extend beyond its row. r=#layout-reviewers

If border-collapse is set and border is set for td but there's an empty
tr, the collapsed border was pushed out wrongly by the empty tr.
Columns borders cannot collapse like row borders as you can't define an empty
column without defining a cell.

Comment 6

[Dianna Smith [:diannaS]]

:dholbert probably too late to uplift for 112, but is there someone that could take a look at the attached patch?

Comment 7

[Daniel Holbert [:dholbert]]

I'll take a look today, yeah. (I'd advise against uplift; our standard cautious ride-the-trains approach should be fine, given that we've apparently been shipping this bug since Firefox 57, via regressor bug 895096.)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0200cc301cb
Ensure block-direction collapsed border does not extend beyond its row. r=dholbert

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39295 for changes under testing/web-platform/tests

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b0200cc301cb

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-03-28 Nightly build on macOS 12.
Verified as fixed on Firefox 113.0b5(build ID: 20230418175842) and Nightly 114.0a1(build ID: 20230419214510) on macOS 12, Windows 10, Ubuntu 22.

Comment 13

[Michael Hohner]

Problem is not fixed in 113. See my original test case. Now at the bottom of the table the vertical lines are too short instead of too long.

Comment 14

[Michael Hohner]

Attachment: Results after "fix"

Screenshot from original test case (zoomed in).