1819268 - Don't pass sourceFile option to acorn.tokenizer

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

https://searchfox.org/mozilla-central/rev/aa3ccd258b64abfd4c5ce56c1f512bc7f65b844c/devtools/client/debugger/src/workers/pretty-print/pretty-fast.js#978-983

function getTokens(input, options) {
  const tokens = [];

  const res = acorn.tokenizer(input, {
    locations: true,
    sourceFile: options.url,

This is probably not a big deal, but we don't make any use of this information on the token, as we have access to the URL when creating SourceNode

https://searchfox.org/mozilla-central/rev/aa3ccd258b64abfd4c5ce56c1f512bc7f65b844c/devtools/client/debugger/src/workers/pretty-print/pretty-fast.js#794

new SourceNode(bufferLine, bufferColumn, options.url, lineStr)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1819268 - [devtools] Don't add sourceFile when fetching tokens for pretty-printing. r=#devtools-reviewers.

We don't make any use of this information, so we'd better not pass the option.

Depends on D171185

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2da5ed051ee6
[devtools] Don't add sourceFile when fetching tokens for pretty-printing. r=jdescottes.

Comment 3

[Cristina Horotan [:chorotan]]

Backed out 2 changesets (Bug 1819268, Bug 1817728) for causing devtools-bundle failure

Backout: https://hg.mozilla.org/integration/autoland/rev/b292e10a9577ccd7a750d0113ac784333795c5ae

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=2da5ed051ee6d59b2fb8056d929a70dcac4b1e15&selectedTaskRun=UoGs3vs5SCGgzR4Yff5EyQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=407286440&repo=autoland&lineNumber=234

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/596dd10a439d
[devtools] Don't add sourceFile when fetching tokens for pretty-printing. r=jdescottes.

Comment 5

[Atila Butkovits]

Backed out for causing Bug 1819531.

Backout link: https://hg.mozilla.org/integration/autoland/rev/6833a092ebd6bea1be81a71cb87a8d55b917e804

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

verified the task does not fail: https://treeherder.mozilla.org/jobs?repo=try&revision=d3f75d7c0d6d02851418e451f24c3c2749952897

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e13f5a1fa3dd
[devtools] Don't add sourceFile when fetching tokens for pretty-printing. r=jdescottes.

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e13f5a1fa3dd