Closed Bug 1819334 Opened 2 years ago Closed 2 years ago

Display an error message when no importable resources can be found for a browser / profile pair

Categories

(Firefox :: Migration, task, P3)

task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: mconley, Assigned: steven100695)

References

Details

Attachments

(1 file)

As parts of bug 1802219 start to close out, chances will increase that we will successfully detect when a browser / profile pair will not contain any resources that can be imported. Now that we can detect that, we can show an appropriate message, rather than "importing nothing successfully".

There's a specification for the error message here: https://www.figma.com/file/PcMkM0ZaSSy3zmS3CYGWNj/Handover---students?node-id=10%3A6662&t=yMAn7Iv6WKobqrm8-4

Severity: -- → N/A
Priority: -- → P3
Blocks: 1821736
No longer blocks: 1801313
Assignee: nobody → steven100695

Note that a similar error message was added by Brian Pham in bug 1809347: https://searchfox.org/mozilla-central/rev/e6a03adbf7930ae0cf131cc3274c80b2aae74e51/browser/components/migration/content/migration-wizard.mjs#116-119

We should use the same structure, and try to make the no-browsers-found and no-browsers-found-message generic so that the classes can be easily re-used for this new error message.

We'll need to show the error message, and hide the other items here: https://searchfox.org/mozilla-central/rev/e6a03adbf7930ae0cf131cc3274c80b2aae74e51/browser/components/migration/content/migration-wizard.mjs#246-266

It might be worth having a class set on everything that should be hidden on error, and then setting an attribute on the page and using a CSS selector to hide all of the relevant things / show the error message.

Attachment #9324900 - Attachment description: Bug 1819334 - Display an error message when no importable resources can be found for a browser / profile pair. r?mconley. → Bug 1819334 - Display an error message when no importable resources can be found for a browser / profile pair. r?mconley!.
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f39c811e4a51 Display an error message when no importable resources can be found for a browser / profile pair. r=mconley,fluent-reviewers.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: