Closed Bug 1819340 Opened 1 year ago Closed 1 year ago

MigrationWizardParent should filter out any migrators that are not enabled

Categories

(Firefox :: Migration, task, P3)

task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: mconley, Assigned: brianpt1106)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This code here: https://searchfox.org/mozilla-central/rev/aa3ccd258b64abfd4c5ce56c1f512bc7f65b844c/browser/components/migration/MigrationWizardParent.sys.mjs#192-218

should check whether or not the migrator is actually enabled. We can do that by updating this condition: https://searchfox.org/mozilla-central/rev/aa3ccd258b64abfd4c5ce56c1f512bc7f65b844c/browser/components/migration/MigrationWizardParent.sys.mjs#195-197

to be like this:

if (!migrator?.enabled) {
  return null;
}

This uses optional chaining to early return a false-y value if migrator is undefined, but if defined, will then check enabled on it.

Severity: -- → N/A
Priority: -- → P3
Assignee: nobody → steven100695
Assignee: steven100695 → brianpt1106
Blocks: 1820208
Blocks: 1821736
No longer blocks: 1801313
Blocks: 1822133
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc49e4d69569
MigrationWizardParent should filter out any migrators that are not enabled r=mconley.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: