1819348 - [wpt-sync] Sync PR 38743 - Rewrite assertion with new semantics

Status: RESOLVED FIXED

(Core :: DOM: Performance APIs, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38743 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38743
Details from upstream follow.

Hao Liu <[e-mail]> wrote:

Rewrite assertion with new semantics

The wpts are flaky. Although the failures are not yet re-produced on try
bots, see last comment of the associated bug, it's believed to be the
first-paint entry not showing up. It has been seen though very rarely on
local machines.

Previous the assertions are on number of entries. It is an indirect way
to verify that what entries should be retrieved with filter option of the
GetEntries() API. Also, the error msg is only about mismatch of
expected and actual numbers, which is not helpful.

This CL rewrites the assertions that verifies directly what entries
should be present and what entries should not. The first-paint is omitted because it is flaky. This is still correct because the test
semantic is that we should be able to get an entry from a same
origin subframe and should not be able to get any from a cross
origin subframe.

Bug:1410530
Change-Id: Iebe3b8d63f11d8ee8d02d2884fed16b4a52a57de
Reviewed-on: https://chromium-review.googlesource.com/4289383
WPT-Export-Revision: ee67a747dba843ea0db2227f8df7d3813ddd8b21

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=921a7cca98cd75a6c91acbdb548b69282ba4fc30

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 1 subtests

Status Summary

Firefox

OK : 9
PASS: 2
FAIL: 7

Chrome

OK : 9
PASS: 9

Safari

OK : 9
PASS: 2
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /performance-timeline/tentative/include-frames-originA-A-A.html [wpt.fyi]
  • GetEntries of a document of origin A, its child frame of origin B and its grandchild frame of origin A.: FAIL (Chrome: PASS, Safari: FAIL)
• /performance-timeline/tentative/include-frames-originA-A.html [wpt.fyi]
  • GetEntries of a document of origin A and its child frame of origin A.: FAIL (Chrome: PASS, Safari: FAIL)
• /performance-timeline/tentative/include-frames-originA-AA.html [wpt.fyi]
  • GetEntries of a document of origin A and its two child frames both of origin A.: FAIL (Chrome: PASS, Safari: FAIL)
• /performance-timeline/tentative/include-frames-originA-AB.html [wpt.fyi]
  • GetEntries of a document of origin A and its two child frames of origin A and B respectively.: FAIL (Chrome: PASS, Safari: FAIL)
• /performance-timeline/tentative/include-frames-originA-B-A.html [wpt.fyi]
  • GetEntries of a document of origin A, its child frame of origin B and its grandchild frame of origin A.: FAIL (Chrome: PASS, Safari: FAIL)
• /performance-timeline/tentative/include-frames-originA-B.html [wpt.fyi]
  • GetEntries of a parent Frame of origin A and its child frame of origin B: FAIL (Chrome: PASS, Safari: FAIL)
• /performance-timeline/tentative/performance-entry-source.html [wpt.fyi]
  • PerformanceEntry source is equal to its respective Window: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b4f1f0d6abe
[wpt PR 38743] - Rewrite assertion with new semantics, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d9fe09d8d2f0
[wpt PR 38743] - Update wpt metadata, a=testonly

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2b4f1f0d6abe
https://hg.mozilla.org/mozilla-central/rev/d9fe09d8d2f0