Closed
Bug 1819359
Opened 2 years ago
Closed 2 years ago
Rename byMouse parameter in removeTab to something clearer
Categories
(Firefox :: Tabbed Browser, task)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
112 Branch
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: mconley, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The byMouse parameter in the removeTab method of tabbrowser is used for unlocking tab sizing when the user is removing the tab with the mouse by interacting with the tab in the tab strip. It has no utility when the tab is being removed by the mouse in other contexts (like via the Tab Manager).
In bug 953217, dao suggested that we rename this parameter to something clearer to avoid people using it for non-tabstrip contexts.
|
Reporter | |
Updated•2 years ago
|
Summary: Rename byMouse parameter to removeTab to something clearer → Rename byMouse parameter in removeTab to something clearer
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f9056f0da0c
Replace removeTab's byMouse parameter with triggeringEvent parameter. r=mconley
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
|
|
Assignee | |
Updated•1 year ago
|
Blocks: tabbrowser-cleanup
You need to log in
before you can comment on or make changes to this bug.
Description
•