1819499 - Encrypted subjects do not show in the message header (shows only ellipsis ...)

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect, P2)

Description

[Magnus Melin [:mkmelin] (away until July 8)]

STR: send yourself an OpenPGP encrypted email. Check the sent folder.
Once you open the message subject will show properly elsewhere, but in the message header you will only see the ...
If you look closely, the unencrypted message subject briefly flashes before turning into "..."

Regressed by initial ash merge.

Comment 1

[Magnus Melin [:mkmelin] (away until July 8)]

(For trunk do note bug 1819246.)

Comment 2

[Magnus Melin [:mkmelin] (away until July 8)]

Attachment: Bug 1819499 - Encrypted subjects were not show in the message header (showed only ellipsis ...). r=kaie

Basically the fix is to set currentHeaderData.subject.headerValue to the value from the db, when we set the document title.
But there were problems with encodings; characters got garbled when passing XPCOM boundaries so needed to make hdr.subject a better type in the idl. Trying
to sync message header and thread pane with the same data created garbled content...
Setting subject for .eml files was unimplemented, so that needed fixing to make the added test work.

Comment 3

[Kai Engert [:KaiE:]]

I think it's important that we get lots of testing for this change, and users are probably waiting for the fix, I suggest to uplift to beta shortly after landing into c-c.

Comment 4

[Wayne Mery (:wsmwk)]

For testers, a try build could be publicised to daily and e2ee topicbox groups

Comment 5

[Kai Engert [:KaiE:]]

Hmm, something went wrong. I have a local beta 113 build plus this patch.
I was switching between two unencrypted messages.
And I toggled "view message body as" between simple and original html.

And suddenly my message had a completely wrong subject, which is now sticky on that message in Thunderbird. (Webmail still shows the correct subject.)

I cannot tell if this is related to this bug, or caused by some other bug in 113.

Comment 6

[Kai Engert [:KaiE:]]

I've removed the .msf file in the ImapMail folder, and Thunderbird refreshed and is shown correct subject again.
I can no longer reproduce the bug.

Comment 7

[Magnus Melin [:mkmelin] (away until July 8)]

I can't say if it's related or not. It wouldn't have been testable before though :/
If the wrong subject gets set in the db, that would be more visible - compared to 102 - with the patch since we will now always use the subject that is in the database for display. The patch isn't (essentially) changing how or when that subject gets set in the db - still enigmailMsgHdrViewOverlay.js setSubject(subject)

Comment 8

[Kai Engert [:KaiE:]]

Ok, let's land into c-c.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4b7f1e4113f1
Encrypted subjects were not show in the message header (showed only ellipsis ...). r=kaie

Comment 10

[Kai Engert [:KaiE:]]

We'll need a follow-up fix for the bustage it caused in an #ifdef DEBUG block (another place that needs to be fixed because of the GetSubject type change). I'll push a fix as soon as my local debug build has completed.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/29afca2988bf
Follow up to fix debug build. r=bustage

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/890f4bd6d552
Follow up to fix Windows MAPI build. r=bustage

Comment 13

[Geoff Lankow (:darktrojan)]

I've backed out all three landings, as this caused test failures in browser_messageMenu.js and browser_ext_message_external.js.

Backout: https://hg.mozilla.org/comm-central/rev/7118ff6d45931ddf9a90a150cb209e723c6444e8

Comment 14

[BB]

When you re-land, please consider simplifying https://hg.mozilla.org/comm-central/rev/4b7f1e4113f1#l14.37 to just:

 NS_IMETHODIMP nsMsgHdr::GetSubject(nsACString& resultSubject) {
+  return m_mdb->RowCellColumnToCharPtr(GetMDBRow(), m_mdb->m_subjectColumnToken,
+                                       getter_Copies(resultSubject));
 }

Comment 15

[Magnus Melin [:mkmelin] (away until July 8)]

Successful try with bustage fixes, adjustment from above, and flag initialization (which was causing the the test failures)
https://treeherder.mozilla.org/jobs?repo=try-comm-central&selectedTaskRun=T4zDWepuQsqwOLPblBfK2g.0&revision=46f72925bf1c04318faca94841b46f030a403401

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/327f82032ed2
Encrypted subjects were not show in the message header (showed only ellipsis ...). r=kaie

Comment 17

[Kai Engert [:KaiE:]]

Can this be uplifted to beta?

Comment 18

[Magnus Melin [:mkmelin] (away until July 8)]

Comment on attachment 9327288 [details]
Bug 1819499 - Encrypted subjects were not show in the message header (showed only ellipsis ...). r=kaie

[Approval Request Comment]
Regression caused by (bug #): supernova
User impact if declined: encrypted subjects don't show in the message header
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): not a trivial patch, but fairly safe

Comment 19

[Wayne Mery (:wsmwk)]

Comment on attachment 9327288 [details]
Bug 1819499 - Encrypted subjects were not show in the message header (showed only ellipsis ...). r=kaie

[Triage Comment]
Approved for beta.

And thanks Magnus for the patch.

Comment 20

[Magnus Melin [:mkmelin] (away until July 8)]

Comment on attachment 9327288 [details]
Bug 1819499 - Encrypted subjects were not show in the message header (showed only ellipsis ...). r=kaie

Holding off on beta until regression is fixed

Comment 21

[Thomas D. (:thomas8)]

Updating whiteboard to [supernova3p]. 20230424_2303

Comment 22

[Magnus Melin [:mkmelin] (away until July 8)]

Comment on attachment 9327288 [details]
Bug 1819499 - Encrypted subjects were not show in the message header (showed only ellipsis ...). r=kaie

(Good to go for beta, with bug 1829502)

Comment 23

[Rob Lemley [:rjl]]

Thunderbird 113.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/d04a044ceeb7