1819556 - Remove nsSocketTransportService::ProbeMaxCount as it's not needed anymore

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

This mechanism was added in bug 692260 to deal with Windows XP not being able to poll more than 1000 sockets. I think we can remove this limitation now, and possibly improve performance a bit.

We can also remove the network_probe_maxcount and NETWORK_SESSION_AT_900FD probes.

Telemetry shows all users are able to poll up to 1000 sockets - see glam

Comment 1

[Gregory Pappas [:gregp]]

Attachment: Bug 1819556 - Remove nsSocketTransportService::ProbeMaxCount r?kershaw!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48bcd4c43c3e
Remove nsSocketTransportService::ProbeMaxCount r=kershaw,necko-reviewers

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bustage on nsSocketTransportService2.cpp

• backout: https://hg.mozilla.org/integration/autoland/rev/546ed21e4ddb012c6ef09e181c0eec89d22ebf78
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=48bcd4c43c3e833bc33696496138c36bdddef23d
• failure log: https://treeherder.mozilla.org/logviewer?job_id=422469523&repo=autoland&lineNumber=22843

[task 2023-07-13T00:12:57.250Z] 00:12:57     INFO -  In file included from Unified_cpp_netwerk_base3.cpp:110:
[task 2023-07-13T00:12:57.250Z] 00:12:57    ERROR -  /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp:1646:17: error: variable has incomplete type 'struct rlimit'
[task 2023-07-13T00:12:57.251Z] 00:12:57     INFO -    struct rlimit rlimitData {};
[task 2023-07-13T00:12:57.251Z] 00:12:57     INFO -                  ^
[task 2023-07-13T00:12:57.252Z] 00:12:57     INFO -  /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp:1646:10: note: forward declaration of 'rlimit'
[task 2023-07-13T00:12:57.252Z] 00:12:57     INFO -    struct rlimit rlimitData {};
[task 2023-07-13T00:12:57.253Z] 00:12:57     INFO -           ^
[task 2023-07-13T00:12:57.254Z] 00:12:57    ERROR -  /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp:1647:17: error: use of undeclared identifier 'RLIMIT_NOFILE'
[task 2023-07-13T00:12:57.254Z] 00:12:57     INFO -    if (getrlimit(RLIMIT_NOFILE, &rlimitData) == -1) {  // rlimit broken - use min
[task 2023-07-13T00:12:57.255Z] 00:12:57     INFO -                  ^
[task 2023-07-13T00:12:57.255Z] 00:12:57    ERROR -  /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp:1667:13: error: use of undeclared identifier 'RLIMIT_NOFILE'
[task 2023-07-13T00:12:57.256Z] 00:12:57     INFO -    setrlimit(RLIMIT_NOFILE, &rlimitData);
[task 2023-07-13T00:12:57.257Z] 00:12:57     INFO -              ^
[task 2023-07-13T00:12:57.257Z] 00:12:57    ERROR -  /builds/worker/checkouts/gecko/netwerk/base/nsSocketTransportService2.cpp:1668:18: error: use of undeclared identifier 'RLIMIT_NOFILE'
[task 2023-07-13T00:12:57.258Z] 00:12:57     INFO -    if ((getrlimit(RLIMIT_NOFILE, &rlimitData) != -1) &&
[task 2023-07-13T00:12:57.258Z] 00:12:57     INFO -                   ^
[task 2023-07-13T00:12:57.259Z] 00:12:57     INFO -  4 errors generated.
[task 2023-07-13T00:12:57.259Z] 00:12:57    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:661: Unified_cpp_netwerk_base3.o] Error 1
[task 2023-07-13T00:12:57.260Z] 00:12:57     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/netwerk/base'

Comment 4

[Gregory Pappas [:gregp]]

Thanks, working on it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dad116419de
Remove nsSocketTransportService::ProbeMaxCount r=kershaw,necko-reviewers

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1dad116419de