1819573 - [wpt-sync] Sync PR 38763 - Fix DCHECK in blink::BodyStreamBuffer::EndLoading

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38763 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38763
Details from upstream follow.

Adam Rice <[e-mail]> wrote:

Fix DCHECK in blink::BodyStreamBuffer::EndLoading

FetchDataLoaderAsFormData::OnStateChange() would call
DidFetchDataLoadFailed() on parse failure. It then would call it again
when it finished reading the input. The double call to
DidFetchDataLoadFailed() caused a DCHECK failure in
BodyStreamBuffer::EndLoading().

Fix it by stopping reading from the input after a parse failure,
ensuring that DidFetchDataLoadFailed() is only called once.

BUG=1412007

Change-Id: I38b7815020e85cbdedc38c207c945b1dee011083
Reviewed-on: https://chromium-review.googlesource.com/4296718
WPT-Export-Revision: 1987fcddb2c412d154c9f63ddb0e71dda74636cf

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=97e7c90cfe1b347b43f05a2887f14a14bcdd45b3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 2

Chrome

OK : 2
PASS: 2

Safari

OK : 2
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fetch/content-type/multipart-malformed.any.html [wpt.fyi]
  • Invalid form data should not crash the browser: FAIL (Chrome: PASS, Safari: FAIL)
• /fetch/content-type/multipart-malformed.any.worker.html [wpt.fyi]
  • Invalid form data should not crash the browser: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29f6e67d4853
[wpt PR 38763] - Fix DCHECK in blink::BodyStreamBuffer::EndLoading, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7a4b98fb3135
[wpt PR 38763] - Update wpt metadata, a=testonly

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/29f6e67d4853
https://hg.mozilla.org/mozilla-central/rev/7a4b98fb3135