1819593 - Set media.videocontrols.lock-video-orientation to false as default in GeckoView

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[Makoto Kato [:m_kato]]

media.videocontrols.lock-video-orientation uses deprecated mozLockOrientation API and this API does nothing.

Fenix/ac uses MediaSession API then ac's MediaSessionFullscreenFeature sets screen orientation.

So it means that media.videocontrols.lock-video-orientation is unused/unnecessary now.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1819593 - Set media.videocontrols.lock-video-orientation to false as default in GeckoView. r=#geckoview-reviewers

media.videocontrols.lock-video-orientation uses deprecated mozLockOrientation
API and this API does nothing.

Fenix/android-component uses MediaSession API and its
MediaSessionFullscreenFeature sets screen orientation.

So it means that media.videocontrols.lock-video-orientation is unused and
unnecessary now. I would like to set false to avoid conflict of same feature
when toolkit/content/widgets/videocontrols.js implements screen orientation API.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09181b684027
Set media.videocontrols.lock-video-orientation to false as default in GeckoView. r=geckoview-reviewers,owlish

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/09181b684027