1819686 - [wpt-sync] Sync PR 38776 - view-transitions: Use default transform-origin for group elements

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38776 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38776
Details from upstream follow.

Khushal Sagar <[e-mail]> wrote:

view-transitions: Use default transform-origin for group elements

The spec text for computing the transform applied to
::view-transition-group elements is as follows:

"A transform that would map element’s border box from the snapshot root
origin to its current visual position."

This value needs to be relative to the center of the element's border
box. The current implementation computes the transform relative to the
element's top left corner with an additional UA style rule for
transform-origin to account for this. This is inconsistent with the UA
styles defined in the spec.

This change fixes the above by computing the transform relative to the
element's border bounding box center and removes the incorrect UA style
rule.

R=[e-mail], [e-mail]

Fixed:1420369
Change-Id: I0ee77266f29f880e8651111129e832b37eea5c48
Reviewed-on: https://chromium-review.googlesource.com/4299931
WPT-Export-Revision: 4805ad204dcffcfad562a153b5045267a0c5c6e6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d520cec545be6948dd0f1b281c6eba40511a263

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

PASS: 1
FAIL: 1

Safari

FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-view-transitions/transform-origin-view-transition-group.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc431f70318b
[wpt PR 38776] - view-transitions: Use default transform-origin for group elements, a=testonly
https://hg.mozilla.org/integration/autoland/rev/63715cc62eec
[wpt PR 38776] - Update wpt metadata, a=testonly

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bc431f70318b
https://hg.mozilla.org/mozilla-central/rev/63715cc62eec