1819726 - DIR attribute in RB and RT is ignored.

Status: RESOLVED FIXED

(Core :: Layout: Ruby, defect, P3)

Description

[Andreas Prilop]

Attachment: ruby-direction.html

User Agent: Mozilla/5.0 (Android 11; Mobile; rv:109.0) Gecko/109.0 Firefox/109.0

Steps to reproduce:

Write <rb dir=rtl> or <rt dir=rtl> inside <ruby>

Actual results:

The DIR attribute is not recognized; the direction is still left-to-right.

Expected results:

The direction should be right-to-left.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

It seems we look at the container directionality when positioning ruby frames.

This comes from bug 1141931... Cc'ing some people which might have context.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

I think it is because this check that skips rb, rt, rbc, rtc, because none of them is eBidiInlineContainer, but they should probably have bidi control / override characters appended. (Actually I'm not sure exactly what eBidiInlineContainer means. There isn't a comment attached.) I suspect replacing frameType == LayoutFrameType::Ruby with RubyUtils::IsRubyBox(frameType) would fix this issue, but not 100% sure whether it could break anything else.

I'm surprised that I didn't try this as part of bug 1141931... but indeed none of the reftest covers these cases.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1819726 - Handle bidi for rb and rt boxes. r=#layout-reviewers

Patch proposed by Xidorn appears to work as expected. Added testcase to WPT.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcf052fea828
Handle bidi for rb and rt boxes. r=emilio

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38788 for changes under testing/web-platform/tests

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bcf052fea828

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot