1819782 - WebSocket.close() should not wait for close

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P2)

Description

[Oliver Medhurst [:canadahonk]]

Looking at this WPT test: https://github.com/web-platform-tests/wpt/blob/master/websockets/interfaces/WebSocket/close/close-connecting.html

ws.close() should not wait for the socket to close, rather just continue and report CLOSING state. We (and Chromium) fail as close() just immediately closes and runs the original onclose handler as the new handler is defined after close() is called. Safari passes.

Marking as unconfirmed as I'm not sure if this is intentional/expected/etc? If someone could confirm/correct that would be great.

Comment 1

[Valentin Gosu [:valentin] (he/him) {{ FYI: OOO 14 June - 4 August }}]

https://www.rfc-editor.org/rfc/rfc6455.html#section-7.1.7

If The WebSocket Connection is Established prior to the point where
the endpoint is required to Fail the WebSocket Connection, the
endpoint SHOULD send a Close frame with an appropriate status code
(Section 7.4) before proceeding to Close the WebSocket Connection.
An endpoint MAY omit sending a Close frame if it believes the other
side is unlikely to be able to receive and process the Close frame,
due to the nature of the error that led the WebSocket connection to
fail in the first place. An endpoint MUST NOT continue to attempt to
process data (including a responding Close frame) from the remote
endpoint after being instructed to Fail the WebSocket Connection.

https://websockets.spec.whatwg.org/#dom-websocket-close

I think the test is right, as we're still handshaking at that time, but I might be wrong.

Comment 2

[Oliver Medhurst [:canadahonk]]

Attachment: Bug 1819782 - Do not wait for close with WebSocket.close()

ws.close() should not wait for the socket to close,
rather just continue and report CLOSING state.

WPT: https://wpt.fyi/results/websockets/interfaces/WebSocket/close/close-connecting.html%3Fdefault

Not sure if this is the correct approach,
it stops closing websockets from being kept alive.

Comment 3

[Valentin Gosu [:valentin] (he/him) {{ FYI: OOO 14 June - 4 August }}]

Attachment: Bug 1819782 - Fix websocket WPT and reenable websocket WPTs r=zcorpan

For some reason the entire dir was disabled in bug 1273201.
Hopefully the frequent intermittents are gone now.

Comment 4

[Valentin Gosu [:valentin] (he/him) {{ FYI: OOO 14 June - 4 August }}]

https://treeherder.mozilla.org/jobs?repo=try&revision=4a05d4b9d4b503edc6f5c7ed37963370441a63bc

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25e8fec60e25
Fix websocket WPT and reenable websocket WPTs r=necko-reviewers,kershaw

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43206 for changes under testing/web-platform/tests

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/25e8fec60e25

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot