1819875 - Remove isRedirect from the network events base parameters

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P1)

Description

[Julian Descottes [:jdescottes]]

With the initial implementation of the network events, I am emitting the redirectCount as part of the base parameters of the event, whereas this is not mentioned in the specs. It should be removed.

Comment 1

[Julian Descottes [:jdescottes]]

After discussing with James, we should first see if it's not worth updating the spec instead to expose the redirectCount.

Filed https://github.com/w3c/webdriver-bidi/issues/375

Comment 2

[James Graham [:jgraham]]

Seems like we're going to add redirectCount and remove isRedirect.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Julian, would you like to work on this bug and wdspec test updates?

Comment 4

[Julian Descottes [:jdescottes]]

Sure!

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1819875 - [bidi] Remove isRedirect from the network events base parameters

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1819875 - [wdspec] Remove isRedirect from webdriver bidi network tests

Depends on D171840

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/421806c4aa61
[bidi] Remove isRedirect from the network events base parameters r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/4359fb9e84ad
[wdspec] Remove isRedirect from webdriver bidi network tests r=webdriver-reviewers,Sasha

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38852 for changes under testing/web-platform/tests

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/421806c4aa61
https://hg.mozilla.org/mozilla-central/rev/4359fb9e84ad

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot