Closed Bug 1819875 Opened 7 months ago Closed 7 months ago

Remove isRedirect from the network events base parameters

Categories

(Remote Protocol :: WebDriver BiDi, defect, P1)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
defect
Points:
1

Tracking

(firefox112 fixed)

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

(Whiteboard: [webdriver:m6][wptsync upstream][webdriver:relnote])

Attachments

(2 files)

Bug 1819875 - [bidi] Remove isRedirect from the network events base parameters
48 bytes, text/x-phabricator-request
Details | Review
Bug 1819875 - [wdspec] Remove isRedirect from webdriver bidi network tests
48 bytes, text/x-phabricator-request
Details | Review

With the initial implementation of the network events, I am emitting the redirectCount as part of the base parameters of the event, whereas this is not mentioned in the specs. It should be removed.

After discussing with James, we should first see if it's not worth updating the spec instead to expose the redirectCount.

Filed https://github.com/w3c/webdriver-bidi/issues/375

Seems like we're going to add redirectCount and remove isRedirect.

Summary: Remove redirectCount from the network events base parameters → Remove iSRedirect from the network events base parameters
Summary: Remove iSRedirect from the network events base parameters → Remove isRedirect from the network events base parameters

Julian, would you like to work on this bug and wdspec test updates?

Flags: needinfo?(jdescottes)

Sure!

Assignee: nobody → jdescottes
Severity: -- → S3
Status: NEW → ASSIGNED
Points: --- → 1
Flags: needinfo?(jdescottes)
Priority: -- → P1
Whiteboard: [webdriver:m6]
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/421806c4aa61
[bidi] Remove isRedirect from the network events base parameters r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/4359fb9e84ad
[wdspec] Remove isRedirect from webdriver bidi network tests r=webdriver-reviewers,Sasha
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38852 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m6] → [webdriver:m6], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/421806c4aa61
https://hg.mozilla.org/mozilla-central/rev/4359fb9e84ad

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m6], [wptsync upstream] → [webdriver:m6][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.