1819938 - Enable `dom.forms.always_allow_key_and_focus_events` and `dom.forms.fieldset_disable_only_descendants.enabled` by default on all channels

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement)

Description

[Adam Vandolder [:avandolder]]

Currently, dom.forms.always_allow_key_and_focus_events.enabled is only turned on nightly. Once stabilized, this should be turned on by default on all channels.

Comment 1

[Hsin-Yi Tsai (she/her)[:hsinyi]]

This will green up these interop-2023-events tests in Release.

Comment 2

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Hi Adam, it looks like we've baked this change long enough and it's time the enable it by default?

Comment 3

[Edgar Chen [:edgar]]

We would like to enable dom.forms.fieldset_disable_only_descendants.enabled together here.

Comment 4

[Edgar Chen [:edgar]]

Attachment: Bug 1819938 - Enable dom.forms.always_allow_key_and_focus_events by default; r?#dom-core,smaug,masayuki

Comment 5

[Edgar Chen [:edgar]]

Attachment: Bug 1819938 - Enable dom.forms.fieldset_disable_only_descendants.enabled by default; r?#dom-core,smaug,masayuki

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea27156f1557
Enable dom.forms.always_allow_key_and_focus_events by default; r=smaug

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ea27156f1557

Comment 8

[Takanori MATSUURA]

Reopened for an unpublished changeset.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1285f5f636d2
Enable dom.forms.fieldset_disable_only_descendants.enabled by default; r=smaug,masayuki,dom-core

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1285f5f636d2

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Is this something we should call out in the Fx135 relnotes? Please add a relnote-firefox request if so.

Comment 12

[Edgar Chen [:edgar]]

This fixes a web compatibility issue related to event dispatching on disabled elements to align with other browsers. I don’t think this needs to be mentioned in the release notes, but let me know if you have a different opinion.