1819996 - React-stockcharts on macOS: stroke slow path shows up in profiles

Status: RESOLVED WORKSFORME

(Core :: Graphics: Canvas2D, defect)

Description

[Markus Stange [:mstange]]

When running https://grandprixbench.netlify.app/?suites=React-Stockcharts on macOS, an appreciable amount of time is spent in the CPU fallback path during stroking: https://share.firefox.dev/3KMDhpj

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:lsalzman, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: Bug 1819996 - Fast-path non-aligned clip rects in DrawTargetWebgl. r?jrmuizel

This adds interpolants to the AA distance calculation to handle the AA'ing of
the clip rect.

Comment 3

[Phabricator Automation]

Comment on attachment 9326920 [details]
Bug 1819996 - Fast-path non-aligned clip rects in DrawTargetWebgl. r?jrmuizel

Revision D174650 was moved to bug 1826134. Setting attachment 9326920 [details] to obsolete.

Comment 4

[Lee Salzman [:lsalzman]]

Oops, put wrong bug number in patch.

Comment 5

[Lee Salzman [:lsalzman]]

There is a high likelihood either React-stockcharts changed to no longer use alpha strokes. In any case, bug 1837068 addresses that issue as well just in case. This issue no longer shows up in profiles.