1820048 - Alphabetically order all FxMS test manifests

Status: RESOLVED WONTFIX

(Firefox :: Messaging System, task, P2)

Description

[Shane Hughes [:aminomancer]]

We're frequently getting Mozlint test-manifest warnings on phabricator because a new rule was added:

WARNING: The mochitest test manifest is not in alphabetical order. Expected ordering:

And basically it wants fully alphabetized ordering. But this isn't something that should be fixed within a patch that was focused on something else and just adds a test. Now, I think when mochitest runs a full manifest, it actually runs them in alphabetical order even if the list is not alphabetized (correct me if I'm wrong). So I don't think fixing the order would actually cause any problems. But if it does, it just seems safest to handle that in a dedicated patch so we can track and troubleshoot more easily and just roll back if necessary.

So, this is that in a nutshell. Alphabetically order all the test(s)/browser/browser.ini files in the directories we own. That should include...

• toolkit/components/messaging-system/schemas/TriggerActionSchemas/test/browser/browser.ini
• toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser.ini
• browser/components/newtab/test/browser/browser.ini
• browser/components/newtab/test/browser/abouthomecache/browser.ini

I'm not sure if xpcshell manifests need to be alphabetic too, haven't edited one since this rule went into effect. Maybe wise to just alphabetize them anyway. The one in toolkit only has one entry so that can be ignored. I think that ultimately just leaves...

• browser/components/newtab/test/xpcshell/xpcshell.ini

Comment 1

[Russell Chan]

Attachment: Bug 1820048 - Alphabetically order all FxMS test manifests

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 4

[Jason Ng]

I’m a new contributor, and I’ll be submitting a patch for this bug soon!

Comment 5

[Shane Hughes [:aminomancer]]

(In reply to Jason Ng from comment #4)

I’m a new contributor, and I’ll be submitting a patch for this bug soon!

Thanks, Jason! Just so you know, the test manifest locations have changed. They are now named browser.toml, and ours are in:

• browser/components/aboutwelcome
• browser/components/asrouter
• toolkit/components/messaging-system

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 7

[Stephanie Cunnane [:scunnane]]

I believe this bug can be closed as WONTFIX, as the test manifests for the directories in comment #5 are already in alphabetical order.

Comment 8

[Shane Hughes [:aminomancer]]

(In reply to Stephanie Cunnane [:scunnane] from comment #7)

I believe this bug can be closed as WONTFIX, as the test manifests for the directories in comment #5 are already in alphabetical order.

Great, thanks for confirming that Stephanie.