1820175 - Align NSS Compiler Warnings with Firefox.

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement, P1)

Description

[Dennis Jackson]

We should enable the same checks in NSS builds as we enable in Firefox.

Comment 1

[Dennis Jackson]

Attachment: Bug 1820175 - Enable various compiler warnings for clang builds. r=jschanck.

This patch enables various compiler warnings in NSS, sourced from
warnings.configure in mozilla-central. Several checks were too noisy
to adopt and were already silenced in mozilla-central builds of NSS.

Comment 2

[Dennis Jackson]

Attachment: Bug 1820175 - Fix various compiler warnings in NSS. r=jschanck.

Depends on D171580

Comment 3

[John Schanck [:jschanck] (out of office Aug 11-18)]

Attachment: Bug 1820175 - Fix unreachable code warning in fuzz builds. r=#nss-reviewers

Comment 4

[John Schanck [:jschanck] (out of office Aug 11-18)]

https://hg.mozilla.org/projects/nss/rev/aee8976b2e92b04682849abaf201a3d8476668e5
https://hg.mozilla.org/projects/nss/rev/c11755bbf31ed8e196c78451eb6b59dbec54fa21
https://hg.mozilla.org/projects/nss/rev/05153c81b1199cffbd313a43b912a998377aa810

Comment 5

[Dennis Jackson]

Attachment: Bug 1820175 - PR_STATIC_ASSERT is cursed. r=jschanck

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)