1820195 - Integer Preferences getting converted to boolean values in preferences policy

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, defect, P2)

Description

[Mike Kaply [:mkaply]]

See:

https://github.com/mozilla/policy-templates/issues/1003

With a Preferences value of

{
  "pdfjs.cursorToolOnLoad": {
    "Value": 1,
    "Status": "user"
  },
  "pdfjs.sidebarViewOnLoad": {
    "Value": 0,
    "Status": "user"
  }
}

You end up with booleans in about:config.

1. This shouldn't happen.
2. This shouldn't be possible because these prefs already exist as default values with ints.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1820195 - Special case pdfjs preferences in policy. r?mstriemer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34f61f1d8186
Special case pdfjs preferences in policy. r=hjones

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/34f61f1d8186

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 9321082 [details]
Bug 1820195 - Special case pdfjs preferences in policy. r?mstriemer

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy only fix, related to enterprise
• User impact if declined: Some PDFjs prefs can't be set via policy
• Fix Landed on Version: 113
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only, automated test.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9321082 [details]
Bug 1820195 - Special case pdfjs preferences in policy. r?mstriemer

This needs a rebased patch for ESR.

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Patch against ESR102

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 9325733 [details] [diff] [review]
Patch against ESR102

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy only fix, related to enterprise
• User impact if declined: Some PDFjs prefs can't be set via policy
• Fix Landed on Version: 113
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only, automated test.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9325733 [details] [diff] [review]
Patch against ESR102

Approved for 102.10esr.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/329acd0679a6