Closed Bug 1820229 Opened 1 year ago Closed 1 year ago

Create the initial button and popup UI for translations

Categories

(Firefox :: Translations, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

References

Details

Attachments

(2 files)

This UI is preliminary and will get the buttons and popup in place to do basic translations. Mostly the goal is to make sure we have the architecture for the popup in place, not the final implementation.

Blocks: 1820240
No longer blocks: 1820240
Blocks: 1820247

This code is untested since it's stubbing out functionality, which will
eventually use PageActions to open up a popup. The final code with the
popup will get tested, but for now rely on the existing test behavior,
without asserting new behavior.

Depends on D173195

Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3ae326dcdf7
Stub out a button in the URL bar for translations; r=nordzilla,desktop-theme-reviewers,flod,Itiel
https://hg.mozilla.org/integration/autoland/rev/18cf612336be
Detect if the translations engine is supported; r=nordzilla
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/766af013a83b
Stub out a button in the URL bar for translations; r=nordzilla,desktop-theme-reviewers,flod,Itiel
https://hg.mozilla.org/integration/autoland/rev/39326e4235ab
Detect if the translations engine is supported; r=nordzilla
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch

@Greg: Is it expected that the translations engine is not supported on a MacBoook with M1 Pro? The extension worked on this device. But this implementation logs the following message:

The translations engine is not supported on this device.

The detection was implemented in the second patch of this bug.

Regressions: 1824838

Ah, I may have gotten the detection wrong then. I filed Bug 1824838 to follow-up. Thanks for letting me know.

Flags: needinfo?(gtatum)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: