Create the initial button and popup UI for translations
Categories
(Firefox :: Translations, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: gregtatum, Assigned: gregtatum)
References
Details
Attachments
(2 files)
This UI is preliminary and will get the buttons and popup in place to do basic translations. Mostly the goal is to make sure we have the architecture for the popup in place, not the final implementation.
Assignee | ||
Comment 1•1 year ago
|
||
This code is untested since it's stubbing out functionality, which will
eventually use PageActions to open up a popup. The final code with the
popup will get tested, but for now rely on the existing test behavior,
without asserting new behavior.
Depends on D173195
Assignee | ||
Comment 2•1 year ago
|
||
Depends on D173196
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3ae326dcdf7 Stub out a button in the URL bar for translations; r=nordzilla,desktop-theme-reviewers,flod,Itiel https://hg.mozilla.org/integration/autoland/rev/18cf612336be Detect if the translations engine is supported; r=nordzilla
Comment 4•1 year ago
|
||
Backed out for causing failures at browser_full_page.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/824c14ab68396152de37a562f09df8ce71f924bf
Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=457474e589d4544345a1f55d4343a4b70ded1d1e&selectedTaskRun=Hrqjdo8ESFSvywMOFoyoyw.0
Failure log: https://treeherder.mozilla.org/logviewer?job_id=410034037&repo=autoland&lineNumber=11999
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/766af013a83b Stub out a button in the URL bar for translations; r=nordzilla,desktop-theme-reviewers,flod,Itiel https://hg.mozilla.org/integration/autoland/rev/39326e4235ab Detect if the translations engine is supported; r=nordzilla
Comment 6•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/766af013a83b
https://hg.mozilla.org/mozilla-central/rev/39326e4235ab
Comment 7•1 year ago
•
|
||
@Greg: Is it expected that the translations engine is not supported on a MacBoook with M1 Pro? The extension worked on this device. But this implementation logs the following message:
The translations engine is not supported on this device.
The detection was implemented in the second patch of this bug.
Assignee | ||
Comment 8•1 year ago
|
||
Ah, I may have gotten the detection wrong then. I filed Bug 1824838 to follow-up. Thanks for letting me know.
Assignee | ||
Updated•1 year ago
|
Description
•