1820256 - Use moz-button-group in the print dialog

Status: RESOLVED FIXED

(Toolkit :: XUL Widgets, task)

Description

[Hanna Jones [:hjones]]

Attachment: Print dialog buttons.png

The print dialog has two buttons grouped together with some code to handle changing the button order based on platform. This could be simplified by using moz-button-group to handle the spacing and ordering of the buttons.

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help. This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Firefox Contributors' Quick Reference, which has answers to most development questions.
3. Start working on this bug.
   • You can see the relevant UI by trying to print any page (ctrl + p on Windows or cmd + p on Mac). The code For the buttons can be found here.
   • You'll need to replace the <section> element with a moz-button-group, then remove any JS code controlling the button order, as well as any CSS that styles the buttons in non-standard ways. You can see some examples of this kind of work in Bug 1802377.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and verify your changes locally. You should also test your change by running some of the printing tests (specifically toolkit/components/printing/tests/browser_cancel_close_print.js and toolkit/components/printing/tests/browser_window_print.js would be good to start with). More information on running tests can be found here. Also check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • Getting your code reviewed
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!

Comment 1

[amit.ritu.ananya]

I would like to work on this bug!

Comment 2

[Hanna Jones [:hjones]]

Hey, that's great! I've gone ahead and assigned the bug to you. If you haven't worked on Firefox before you'll need to follow these steps to get set up to work on the codebase. If you run into any issues with that or have any problems/questions with the work involved in fixing this bug feel free to reach out. You can use the form below to request information from me, or send me a message in the #reusable-components channel on Matrix.

Comment 3

[Lata]

Hey! Can I work on this bug?

Comment 4

[Hanna Jones [:hjones]]

Hey Lata, this bug is already assigned and I would like to give the current assignee more time to submit a patch. If you're looking for a new task, you can find a list of unassigned Firefox bugs here: https://codetribute.mozilla.org/projects/ff

Comment 5

[Hanna Jones [:hjones]]

Hi :amit.ritu.ananya are you still working on this and planning to submit a patch? Let me know if you have any questions. Thanks!

Comment 6

[Ebilite Uchenna]

As an outreachy applicant, can I work on this bug. Will love giving it my all

Comment 7

[Ebilite Uchenna]

Attachment: Bug 1820256 - Implemented Use moz-button-group in the print dialog. r?hjones

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd442d508741
Implemented Use moz-button-group in the print dialog. r=hjones

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bd442d508741