Use moz-button-group in about:logins import error dialog
Categories
(Toolkit :: UI Widgets, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: hjones, Assigned: divyaramaswamy2, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [lang=html][lang=css][lang=js][fidefe-reusable-components])
Attachments
(2 files)
Import error dialog.png
The buttons in the import error dialog are styled in a way that doesn't quite match our standard buttons. The button order also doesn't seem to change based on platform (i.e. it's the same on Mac and Windows, which is unexpected). We could use the moz-button-group component here to make the styling and ordering more consistent.
The relevant html code can be found here. We'll also probably want to modify some of the CSS in generic-dialog.css, though there is at least one other dialog using these styles.
The dialog itself can be viewed by:
- navigating to
about:logins - opening the multiprocess browser toolbox and selecting the
about:loginsiframe - querying for the
import-error-dialogin the console:
let dialog = document.querySelector("import-error-dialog");
- calling "show" on the dialog using a valid error message name:
dialog.show("CONFLICTING_VALUES_ERROR")
|
Assignee | |
Comment 1•1 year ago
|
||
Hi! I'm interested in working on this bug and would love to be assigned this.
Hi Hanna, I am looking into this bug and interested in working on the next steps.
Hi! I'm interested in working on this bug:)
|
Reporter | |
Comment 4•1 year ago
|
||
Hey all, I'm assigning this to divyaramaswamy2 as they requested first, but if they decide not to put up a patch for this work I'll open it back up again. Thanks for all of your interest!
|
|
Assignee | |
Comment 5•1 year ago
|
||
(In reply to Hanna Jones [:hjones] from comment #4)
Hey all, I'm assigning this to divyaramaswamy2 as they requested first, but if they decide not to put up a patch for this work I'll open it back up again. Thanks for all of your interest!
Thanks Hanna! I'll get to work on this now.
|
|
Reporter | |
Updated•1 year ago
|
|
|
Reporter | |
Updated•1 year ago
|
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 6•1 year ago
|
||
Pushed by hjones@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2a46d4f61146 standardize button styling in import error dialog. r=hjones,credential-management-reviewers,mtigley
|
||
Comment 8•1 year ago
|
||
| bugherder | ||
Description
•