Closed Bug 1820282 Opened 7 months ago Closed 6 months ago

Use moz-button-group in about:logins import error dialog

Categories

(Toolkit :: XUL Widgets, task)

Product:
Toolkit
Component:
XUL Widgets
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: hjones, Assigned: divyaramaswamy2, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=html][lang=css][lang=js][fidefe-reusable-components])

Attachments

(2 files)

Import error dialog.png
78.65 KB, image/png
Details
Bug 1820282 - standardize button styling in import error dialog. r?hjones
48 bytes, text/x-phabricator-request
Details | Review
Attached image Import error dialog.png —

The buttons in the import error dialog are styled in a way that doesn't quite match our standard buttons. The button order also doesn't seem to change based on platform (i.e. it's the same on Mac and Windows, which is unexpected). We could use the moz-button-group component here to make the styling and ordering more consistent.

The relevant html code can be found here. We'll also probably want to modify some of the CSS in generic-dialog.css, though there is at least one other dialog using these styles.

The dialog itself can be viewed by:

  1. navigating to about:logins
  2. opening the multiprocess browser toolbox and selecting the about:logins iframe
  3. querying for the import-error-dialog in the console:
let dialog = document.querySelector("import-error-dialog");
  1. calling "show" on the dialog using a valid error message name:
dialog.show("CONFLICTING_VALUES_ERROR")

Hi! I'm interested in working on this bug and would love to be assigned this.

Hi Hanna, I am looking into this bug and interested in working on the next steps.

Hi! I'm interested in working on this bug:)

Flags: needinfo?(hjones)

Hey all, I'm assigning this to divyaramaswamy2 as they requested first, but if they decide not to put up a patch for this work I'll open it back up again. Thanks for all of your interest!

Assignee: nobody → divyaramaswamy2
Status: NEW → ASSIGNED
Flags: needinfo?(hjones)

(In reply to Hanna Jones [:hjones] from comment #4)

Hey all, I'm assigning this to divyaramaswamy2 as they requested first, but if they decide not to put up a patch for this work I'll open it back up again. Thanks for all of your interest!

Thanks Hanna! I'll get to work on this now.

Whiteboard: [lang=html][lang=css][lang=js] → [lang=html][lang=css][lang=js][[fidefe-reusable-components]
Whiteboard: [lang=html][lang=css][lang=js][[fidefe-reusable-components] → [lang=html][lang=css][lang=js][fidefe-reusable-components]
Pushed by hjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a46d4f61146
standardize button styling in import error dialog. r=hjones,credential-management-reviewers,mtigley

https://hg.mozilla.org/mozilla-central/rev/2a46d4f61146

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.