1820408 - Wrong-thread crash handling a close message

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

https://treeherder.mozilla.org/logviewer?job_id=407889293&repo=try&lineNumber=7126

Crash due to wrong-thread assertion in WebTransportSessionProxy::CloseSession(), called on Socket Thread.

Looks to be intermittent

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

with logging: https://treeherder.mozilla.org/logviewer?job_id=407903057&repo=try&lineNumber=41316

Comment 2

[Kershaw Chang [:kershaw]]

This happens because that RetargetTo is called too late.
I assume this can be easily fixed by calling RetargetTo earlier than resolving mResolver.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1820408 - Call WebTransportSessionProxy::RetargetTo earlier, r=jesup

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e738bc9b389d
Call WebTransportSessionProxy::RetargetTo earlier, r=jesup,necko-reviewers

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e738bc9b389d